Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: google_apis/gcm/gcm_client_impl_unittest.cc

Issue 226223005: Revert of Removing the mock-keychain related bool from GCMStore constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gcm/gcm_client_impl.cc ('k') | google_apis/gcm/tools/mcs_probe.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/gcm_client_impl_unittest.cc
diff --git a/google_apis/gcm/gcm_client_impl_unittest.cc b/google_apis/gcm/gcm_client_impl_unittest.cc
index 39fb3f1de75112f1698e7e340eb3518d48173152..229feab49888790de8203e40bd22f7a01b41abb1 100644
--- a/google_apis/gcm/gcm_client_impl_unittest.cc
+++ b/google_apis/gcm/gcm_client_impl_unittest.cc
@@ -13,7 +13,6 @@
#include "google_apis/gcm/base/mcs_util.h"
#include "google_apis/gcm/engine/fake_connection_factory.h"
#include "google_apis/gcm/engine/fake_connection_handler.h"
-#include "google_apis/gcm/engine/gcm_store_impl.h"
#include "google_apis/gcm/protocol/android_checkin.pb.h"
#include "google_apis/gcm/protocol/checkin.pb.h"
#include "google_apis/gcm/protocol/mcs.pb.h"
@@ -118,10 +117,6 @@
virtual ~FakeGCMInternalsBuilder();
virtual scoped_ptr<base::Clock> BuildClock() OVERRIDE;
- virtual scoped_ptr<GCMStore> BuildGCMStore(
- const base::FilePath& path,
- const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner)
- OVERRIDE;
virtual scoped_ptr<MCSClient> BuildMCSClient(
const std::string& version,
base::Clock* clock,
@@ -140,16 +135,6 @@
scoped_ptr<base::Clock> FakeGCMInternalsBuilder::BuildClock() {
return make_scoped_ptr<base::Clock>(new base::SimpleTestClock());
-}
-
-scoped_ptr<GCMStore> FakeGCMInternalsBuilder::BuildGCMStore(
- const base::FilePath& path,
- const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner) {
-#if defined(OS_MACOSX)
- OSCrypt::UseMockKeychain(true);
-#endif
- return make_scoped_ptr<GCMStore>(
- new GCMStoreImpl(path, blocking_task_runner));
}
scoped_ptr<MCSClient> FakeGCMInternalsBuilder::BuildMCSClient(
« no previous file with comments | « google_apis/gcm/gcm_client_impl.cc ('k') | google_apis/gcm/tools/mcs_probe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698