Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2262103002: [wasm] Pass the context to ToJS. (Closed)

Created:
4 years, 4 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@fix-imports-context
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Pass the context to ToJS. The original code assumed that the context that is needed in wasm-compiler.cc in ToJS() can be acquired from the module_. However, when ToJS() is used in the JSToWasm wrapper, module_ is not initialized. With this CL the context is passed explicitly to ToJS(). R=titzer@chromium.org TEST=mjsunit/wasm/ffi-error.js BUG=chromium:639492

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -20 lines) Patch
M src/compiler/wasm-compiler.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 8 chunks +14 lines, -12 lines 1 comment Download
M src/wasm/wasm-module.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/ffi-error.js View 1 chunk +21 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (4 generated)
ahaas
4 years, 4 months ago (2016-08-22 07:35:18 UTC) #1
titzer
4 years, 4 months ago (2016-08-22 08:28:14 UTC) #6
https://codereview.chromium.org/2262103002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2262103002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:2562: ToJS(retval, context,
Maybe this take a context_node, since we already have a context as an incoming
parameter.

Powered by Google App Engine
This is Rietveld 408576698