Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2263953002: [wasm] Use the right context in the wasm-to-js wrapper. (Closed)

Created:
4 years, 4 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use the right context in the wasm-to-js wrapper. With this CL the wasm-to-js wrapper uses the current context at the time the wasm module was instantiated, even if the wasm module is later moved to a different context. R=titzer@chromium.org TEST=mjsunit/wasm/wasm-realms.js

Patch Set 1 #

Patch Set 2 : Cleanup the test. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -27 lines) Patch
M src/asmjs/asm-js.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +0 lines, -1 line 1 comment Download
M src/wasm/wasm-js.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 7 chunks +14 lines, -10 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
A test/mjsunit/wasm/wasm-realms.js View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
ahaas
4 years, 4 months ago (2016-08-22 06:01:16 UTC) #1
ahaas
On 2016/08/22 at 08:47:48, ahaas wrote: > ahaas@chromium.org changed reviewers: > + rossberg@chromium.org Andreas, could ...
4 years, 4 months ago (2016-08-22 08:48:20 UTC) #9
rossberg
On 2016/08/22 08:48:20, ahaas wrote: > On 2016/08/22 at 08:47:48, ahaas wrote: > > mailto:ahaas@chromium.org ...
4 years, 4 months ago (2016-08-22 11:18:44 UTC) #12
titzer
4 years, 4 months ago (2016-08-22 11:32:03 UTC) #13
lgtm

https://codereview.chromium.org/2263953002/diff/20001/src/runtime/runtime-com...
File src/runtime/runtime-compiler.cc (left):

https://codereview.chromium.org/2263953002/diff/20001/src/runtime/runtime-com...
src/runtime/runtime-compiler.cc:88: 
Spurious whitespace change

Powered by Google App Engine
This is Rietveld 408576698