Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2262063002:
Adjust callers and networking delegates in ios/ to modified APIs (Closed)
|
Created:
4 years, 4 months ago by maksims (do not use this acc) Modified:
4 years, 3 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, sdefresne+watch_chromium.org, mmenke Base URL:
https://chromium.googlesource.com/chromium/src.git@URLRequestRead Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdjust callers and networking delegates in ios/ to modified APIs
Use modified Read and delegate methods from the following CL-
https://codereview.chromium.org/2262653003/
BUG=423484
Committed: https://crrev.com/5af9098dfe78b06569f9007caa84349beca417df
Committed: https://crrev.com/40d1bef7b6747e1c73d06899276f83298725945f
Cr-Original-Commit-Position: refs/heads/master@{#416528}
Cr-Commit-Position: refs/heads/master@{#416584}
Patch Set 1 #Patch Set 2 : rebased + minor fixes #Patch Set 3 : typo #
Total comments: 4
Patch Set 4 : revert format crw_web_controller.mm #Patch Set 5 : forgotten call #Patch Set 6 : rebased #Messages
Total messages: 40 (28 generated)
The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Adjust callers and networking delegates in ios/ to modified APIs BUG= ========== to ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 ==========
maksim.sisov@intel.com changed reviewers: + droger@chromium.org, marq@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Exceeded global retry quota
please take a look
The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CC mmenke@
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2262063002/diff/40001/ios/net/crn_http_protoc... File ios/net/crn_http_protocol_handler.mm (right): https://codereview.chromium.org/2262063002/diff/40001/ios/net/crn_http_protoc... ios/net/crn_http_protocol_handler.mm:543: request->Read(buffer_.get(), kIOBufferSize, &bytes_read); Do you want to update this call too? https://codereview.chromium.org/2262063002/diff/40001/ios/web/web_state/ui/cr... File ios/web/web_state/ui/crw_web_controller.mm (right): https://codereview.chromium.org/2262063002/diff/40001/ios/web/web_state/ui/cr... ios/web/web_state/ui/crw_web_controller.mm:1753: }]; If this is just a formatting change, I would not include it in this CL. It looks pretty unrelated. Feel free to submit this as a separate CL if you want though.
https://codereview.chromium.org/2262063002/diff/40001/ios/net/crn_http_protoc... File ios/net/crn_http_protocol_handler.mm (right): https://codereview.chromium.org/2262063002/diff/40001/ios/net/crn_http_protoc... ios/net/crn_http_protocol_handler.mm:543: request->Read(buffer_.get(), kIOBufferSize, &bytes_read); On 2016/09/05 09:21:31, droger wrote: > Do you want to update this call too? Yes. https://codereview.chromium.org/2262653003/diff/570001/net/url_request/url_re... line 571. Old Read() is deprecated and I'll remove it as soon as all the callers are modified. https://codereview.chromium.org/2262063002/diff/40001/ios/web/web_state/ui/cr... File ios/web/web_state/ui/crw_web_controller.mm (right): https://codereview.chromium.org/2262063002/diff/40001/ios/web/web_state/ui/cr... ios/web/web_state/ui/crw_web_controller.mm:1753: }]; On 2016/09/05 09:21:31, droger wrote: > If this is just a formatting change, I would not include it in this CL. It looks > pretty unrelated. > > Feel free to submit this as a separate CL if you want though. Ok, thanks! I'll revert.
The CQ bit was checked by maksim.sisov@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org Link to the patchset: https://codereview.chromium.org/2262063002/#ps60001 (title: "revert format crw_web_controller.mm")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 ========== to ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 ========== to ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 Committed: https://crrev.com/5af9098dfe78b06569f9007caa84349beca417df Cr-Commit-Position: refs/heads/master@{#416528} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/5af9098dfe78b06569f9007caa84349beca417df Cr-Commit-Position: refs/heads/master@{#416528}
Message was sent while issue was closed.
Patchset #5 (id:80001) has been deleted
Message was sent while issue was closed.
Description was changed from ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 Committed: https://crrev.com/5af9098dfe78b06569f9007caa84349beca417df Cr-Commit-Position: refs/heads/master@{#416528} ========== to ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 Committed: https://crrev.com/5af9098dfe78b06569f9007caa84349beca417df Cr-Commit-Position: refs/heads/master@{#416528} ==========
The CQ bit was checked by maksim.sisov@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org Link to the patchset: https://codereview.chromium.org/2262063002/#ps100001 (title: "forgotten call")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was unchecked by maksim.sisov@intel.com
The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by maksim.sisov@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org Link to the patchset: https://codereview.chromium.org/2262063002/#ps120001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 Committed: https://crrev.com/5af9098dfe78b06569f9007caa84349beca417df Cr-Commit-Position: refs/heads/master@{#416528} ========== to ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 Committed: https://crrev.com/5af9098dfe78b06569f9007caa84349beca417df Cr-Commit-Position: refs/heads/master@{#416528} ==========
Message was sent while issue was closed.
Committed patchset #6 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 Committed: https://crrev.com/5af9098dfe78b06569f9007caa84349beca417df Cr-Commit-Position: refs/heads/master@{#416528} ========== to ========== Adjust callers and networking delegates in ios/ to modified APIs Use modified Read and delegate methods from the following CL- https://codereview.chromium.org/2262653003/ BUG=423484 Committed: https://crrev.com/5af9098dfe78b06569f9007caa84349beca417df Committed: https://crrev.com/40d1bef7b6747e1c73d06899276f83298725945f Cr-Original-Commit-Position: refs/heads/master@{#416528} Cr-Commit-Position: refs/heads/master@{#416584} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/40d1bef7b6747e1c73d06899276f83298725945f Cr-Commit-Position: refs/heads/master@{#416584} |
