Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 226203004: Fix skia ganesh resources leak. (Closed)

Created:
6 years, 8 months ago by dshwang
Modified:
6 years, 8 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Base URL:
https://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix skia ganesh resources leak. Currently, ~GrContextForWebGraphicsContext3D() calls GrContext::contextDestroyed() before destructing a context provider. It causes gpu resource leak because contextDestroyed() abandons all gpu resources, so GrContext destructor cannot have a chance to clean gpu resources. chromium doesn't need to use GrContext::contextDestroyed() because chromium controls the lifecycle of a context provider. However, when a context provider is lost, chromium must call GrContext::contextLost(). In addition, TestInProcessContextProvider must destruct GrContext before destructing gpu::GLInProcessContext. BUG=360107 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M cc/test/test_in_process_context_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/test_in_process_context_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/common/gpu/grcontext_for_webgraphicscontext3d.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/gpu/grcontext_for_webgraphicscontext3d.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
dshwang
I found this bug when I was working on http://crrev.com/223343003 this bug is introduced in ...
6 years, 8 months ago (2014-04-04 18:20:01 UTC) #1
dshwang
Please refer to comments of contextLost() and contextDestroyed() https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/include/gpu/GrContext.h&q=grcontext&sq=package:chromium&l=101
6 years, 8 months ago (2014-04-04 18:23:34 UTC) #2
Justin Novosad
+bsalomon
6 years, 8 months ago (2014-04-04 18:27:09 UTC) #3
piman
LGTM if others are happy
6 years, 8 months ago (2014-04-04 22:45:14 UTC) #4
dshwang
On 2014/04/04 22:45:14, piman wrote: > LGTM if others are happy Thank you for review. ...
6 years, 8 months ago (2014-04-07 12:10:36 UTC) #5
Stephen White
On 2014/04/07 12:10:36, dshwang wrote: > On 2014/04/04 22:45:14, piman wrote: > > LGTM if ...
6 years, 8 months ago (2014-04-07 12:23:06 UTC) #6
dshwang
On 2014/04/07 12:23:06, Stephen White wrote: > Looks ok, but Brian is the expert here. ...
6 years, 8 months ago (2014-04-07 12:30:42 UTC) #7
bsalomon_chromium
On 2014/04/07 12:30:42, dshwang wrote: > On 2014/04/07 12:23:06, Stephen White wrote: > > Looks ...
6 years, 8 months ago (2014-04-07 13:44:58 UTC) #8
bsalomon_chromium
On 2014/04/07 12:30:42, dshwang wrote: > On 2014/04/07 12:23:06, Stephen White wrote: > > Looks ...
6 years, 8 months ago (2014-04-07 13:44:59 UTC) #9
dshwang
On 2014/04/07 13:44:59, bsalomon1 wrote: > On 2014/04/07 12:30:42, dshwang wrote: > > On 2014/04/07 ...
6 years, 8 months ago (2014-04-07 13:49:40 UTC) #10
dshwang
The CQ bit was checked by dongseong.hwang@intel.com
6 years, 8 months ago (2014-04-07 13:49:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/226203004/1
6 years, 8 months ago (2014-04-07 13:49:49 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 18:03:44 UTC) #13
Message was sent while issue was closed.
Change committed as 262153

Powered by Google App Engine
This is Rietveld 408576698