Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/extensions/api/language_settings_private/language_settings_private_api.h

Issue 2261903002: Fix race condition in MD Settings Languages page causing inconsistent settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update histograms Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/language_settings_private/language_settings_private_api.h
diff --git a/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.h b/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.h
index e1007160dc5a00cfc5d2b695265d4b92ab220a8e..662298d6e7d44fb7c2fccbd3d9706591b74cd7f4 100644
--- a/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.h
+++ b/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.h
@@ -30,16 +30,16 @@ class LanguageSettingsPrivateGetLanguageListFunction
DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateGetLanguageListFunction);
};
-// Implements the languageSettingsPrivate.setLanguageList method.
-class LanguageSettingsPrivateSetLanguageListFunction
+// Implements the languageSettingsPrivate.enableLanguage method.
+class LanguageSettingsPrivateEnableLanguageFunction
: public UIThreadExtensionFunction {
public:
- LanguageSettingsPrivateSetLanguageListFunction();
- DECLARE_EXTENSION_FUNCTION("languageSettingsPrivate.setLanguageList",
- LANGUAGESETTINGSPRIVATE_SETLANGUAGELIST)
+ LanguageSettingsPrivateEnableLanguageFunction();
+ DECLARE_EXTENSION_FUNCTION("languageSettingsPrivate.enableLanguage",
+ LANGUAGESETTINGSPRIVATE_ENABLELANGUAGE)
protected:
- ~LanguageSettingsPrivateSetLanguageListFunction() override;
+ ~LanguageSettingsPrivateEnableLanguageFunction() override;
// ExtensionFunction overrides.
ResponseAction Run() override;
@@ -47,7 +47,27 @@ class LanguageSettingsPrivateSetLanguageListFunction
private:
ChromeExtensionFunctionDetails chrome_details_;
- DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateSetLanguageListFunction);
+ DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateEnableLanguageFunction);
+};
+
+// Implements the languageSettingsPrivate.disableLanguage method.
+class LanguageSettingsPrivateDisableLanguageFunction
+ : public UIThreadExtensionFunction {
+ public:
+ LanguageSettingsPrivateDisableLanguageFunction();
+ DECLARE_EXTENSION_FUNCTION("languageSettingsPrivate.disableLanguage",
+ LANGUAGESETTINGSPRIVATE_DISABLELANGUAGE)
+
+ protected:
+ ~LanguageSettingsPrivateDisableLanguageFunction() override;
+
+ // ExtensionFunction overrides.
+ ResponseAction Run() override;
+
+ private:
+ ChromeExtensionFunctionDetails chrome_details_;
+
+ DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateDisableLanguageFunction);
};
// Implements the languageSettingsPrivate.getSpellcheckDictionaryStatuses
« no previous file with comments | « no previous file | chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698