Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: chrome/browser/extensions/api/language_settings_private/language_settings_private_api.h

Issue 2261903002: Fix race condition in MD Settings Languages page causing inconsistent settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update histograms Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_LANGUAGE_SETTINGS_PRIVATE_LANGUAGE_SETTING S_PRIVATE_API_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_LANGUAGE_SETTINGS_PRIVATE_LANGUAGE_SETTING S_PRIVATE_API_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_LANGUAGE_SETTINGS_PRIVATE_LANGUAGE_SETTING S_PRIVATE_API_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_LANGUAGE_SETTINGS_PRIVATE_LANGUAGE_SETTING S_PRIVATE_API_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/extensions/chrome_extension_function_details.h" 9 #include "chrome/browser/extensions/chrome_extension_function_details.h"
10 #include "chrome/browser/spellchecker/spellcheck_custom_dictionary.h" 10 #include "chrome/browser/spellchecker/spellcheck_custom_dictionary.h"
(...skipping 12 matching lines...) Expand all
23 protected: 23 protected:
24 ~LanguageSettingsPrivateGetLanguageListFunction() override; 24 ~LanguageSettingsPrivateGetLanguageListFunction() override;
25 25
26 // ExtensionFunction overrides. 26 // ExtensionFunction overrides.
27 ResponseAction Run() override; 27 ResponseAction Run() override;
28 28
29 private: 29 private:
30 DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateGetLanguageListFunction); 30 DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateGetLanguageListFunction);
31 }; 31 };
32 32
33 // Implements the languageSettingsPrivate.setLanguageList method. 33 // Implements the languageSettingsPrivate.enableLanguage method.
34 class LanguageSettingsPrivateSetLanguageListFunction 34 class LanguageSettingsPrivateEnableLanguageFunction
35 : public UIThreadExtensionFunction { 35 : public UIThreadExtensionFunction {
36 public: 36 public:
37 LanguageSettingsPrivateSetLanguageListFunction(); 37 LanguageSettingsPrivateEnableLanguageFunction();
38 DECLARE_EXTENSION_FUNCTION("languageSettingsPrivate.setLanguageList", 38 DECLARE_EXTENSION_FUNCTION("languageSettingsPrivate.enableLanguage",
39 LANGUAGESETTINGSPRIVATE_SETLANGUAGELIST) 39 LANGUAGESETTINGSPRIVATE_ENABLELANGUAGE)
40 40
41 protected: 41 protected:
42 ~LanguageSettingsPrivateSetLanguageListFunction() override; 42 ~LanguageSettingsPrivateEnableLanguageFunction() override;
43 43
44 // ExtensionFunction overrides. 44 // ExtensionFunction overrides.
45 ResponseAction Run() override; 45 ResponseAction Run() override;
46 46
47 private: 47 private:
48 ChromeExtensionFunctionDetails chrome_details_; 48 ChromeExtensionFunctionDetails chrome_details_;
49 49
50 DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateSetLanguageListFunction); 50 DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateEnableLanguageFunction);
51 };
52
53 // Implements the languageSettingsPrivate.disableLanguage method.
54 class LanguageSettingsPrivateDisableLanguageFunction
55 : public UIThreadExtensionFunction {
56 public:
57 LanguageSettingsPrivateDisableLanguageFunction();
58 DECLARE_EXTENSION_FUNCTION("languageSettingsPrivate.disableLanguage",
59 LANGUAGESETTINGSPRIVATE_DISABLELANGUAGE)
60
61 protected:
62 ~LanguageSettingsPrivateDisableLanguageFunction() override;
63
64 // ExtensionFunction overrides.
65 ResponseAction Run() override;
66
67 private:
68 ChromeExtensionFunctionDetails chrome_details_;
69
70 DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateDisableLanguageFunction);
51 }; 71 };
52 72
53 // Implements the languageSettingsPrivate.getSpellcheckDictionaryStatuses 73 // Implements the languageSettingsPrivate.getSpellcheckDictionaryStatuses
54 // method. 74 // method.
55 class LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction 75 class LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction
56 : public UIThreadExtensionFunction { 76 : public UIThreadExtensionFunction {
57 public: 77 public:
58 LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction(); 78 LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction();
59 DECLARE_EXTENSION_FUNCTION( 79 DECLARE_EXTENSION_FUNCTION(
60 "languageSettingsPrivate.getSpellcheckDictionaryStatuses", 80 "languageSettingsPrivate.getSpellcheckDictionaryStatuses",
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 230
211 private: 231 private:
212 ChromeExtensionFunctionDetails chrome_details_; 232 ChromeExtensionFunctionDetails chrome_details_;
213 233
214 DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateRemoveInputMethodFunction); 234 DISALLOW_COPY_AND_ASSIGN(LanguageSettingsPrivateRemoveInputMethodFunction);
215 }; 235 };
216 236
217 } // namespace extensions 237 } // namespace extensions
218 238
219 #endif // CHROME_BROWSER_EXTENSIONS_API_LANGUAGE_SETTINGS_PRIVATE_LANGUAGE_SETT INGS_PRIVATE_API_H_ 239 #endif // CHROME_BROWSER_EXTENSIONS_API_LANGUAGE_SETTINGS_PRIVATE_LANGUAGE_SETT INGS_PRIVATE_API_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698