Use BasicNativePage in PhysicalWebDiagnostics

Use BasicNativePage in PhysicalWebDiagnostics

The recently created BasicNativePage is perfect for
chrome://physical-web.  Moreover, it gets rid of a nasty bug which
displays things poorly on tablets.

BUG=639349
Committed: https://crrev.com/ddfdd7aeb62362ff752eb38396d9c6353c50e4cc
Cr-Commit-Position: refs/heads/master@{#413476}

[cco3, 2016-08-19 23:15:42]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[mattreynolds, 2016-08-19 23:28:31]

lgtm

https://codereview.chromium.org/2261883002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
(right):

https://codereview.chromium.org/2261883002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:227:
// NativePage overrides
Remove comment (or move it with the remaining overrides)

[cco3, 2016-08-19 23:32:23]

cco3@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2016-08-19 23:40:47]

Ah, I guess the key is in the top margin that's set in the BasicNativePage
constructor.

lgtm

[cco3, 2016-08-19 23:42:35]

On 2016/08/19 23:40:47, dfalcantara wrote:
> Ah, I guess the key is in the top margin that's set in the BasicNativePage
> constructor.

Yea, that's probably it.

> 
> lgtm

[cco3, 2016-08-19 23:42:42]

The CQ bit was checked by cco3@chromium.org

[commit-bot: I haz the power, 2016-08-19 23:43:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 03:35:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 03:35:30]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[cco3, 2016-08-22 17:08:59]

The CQ bit was checked by cco3@chromium.org

[cco3, 2016-08-22 17:08:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2261883002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-22 17:09:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 18:06:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-22 18:08:42]

Description was changed from

==========
Use BasicNativePage in PhysicalWebDiagnostics

The recently created BasicNativePage is perfect for
chrome://physical-web.  Moreover, it gets rid of a nasty bug which
displays things poorly on tablets.

BUG=639349
==========

to

==========
Use BasicNativePage in PhysicalWebDiagnostics

The recently created BasicNativePage is perfect for
chrome://physical-web.  Moreover, it gets rid of a nasty bug which
displays things poorly on tablets.

BUG=639349

Committed: https://crrev.com/ddfdd7aeb62362ff752eb38396d9c6353c50e4cc
Cr-Commit-Position: refs/heads/master@{#413476}
==========

[commit-bot: I haz the power, 2016-08-22 18:08:43]

Patchset 3 (id:??) landed as
https://crrev.com/ddfdd7aeb62362ff752eb38396d9c6353c50e4cc
Cr-Commit-Position: refs/heads/master@{#413476}