chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java - Issue 2261883002: Use BasicNativePage in PhysicalWebDiagnostics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java

Issue 2261883002: Use BasicNativePage in PhysicalWebDiagnostics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/Utils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java

index 70c5454b8a1ca335490f10fc2188ec2b82d65c82..e551b602fa6febe7d8a2bc60e61412dfffe7ba05 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java

@@ -233,9 +233,9 @@ public class PhysicalWebUma {

handleEnum(context, createStateString(LOCATION_PERMISSION, actionName),

locationUtils.hasAndroidLocationPermission() ? 1 : 0, BOOLEAN_BOUNDARY);

handleEnum(context, createStateString(BLUETOOTH, actionName),

- Utils.getBluetoothEnabledStatus(context), TRISTATE_BOUNDARY);

+ Utils.getBluetoothEnabledStatus(), TRISTATE_BOUNDARY);

handleEnum(context, createStateString(DATA_CONNECTION, actionName),

- Utils.isDataConnectionActive(context) ? 1 : 0, BOOLEAN_BOUNDARY);

+ Utils.isDataConnectionActive() ? 1 : 0, BOOLEAN_BOUNDARY);

int preferenceState = 2;

if (!PhysicalWeb.isOnboarding()) {

preferenceState = PhysicalWeb.isPhysicalWebPreferenceEnabled() ? 1 : 0;