Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226183004: Renamed OutputConfigurator to DisplayConfigurator (Closed)

Created:
6 years, 8 months ago by dnicoara
Modified:
6 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, tfarina, davemoore+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Renamed OutputConfigurator to DisplayConfigurator BUG=333413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262183

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -3132 lines) Patch
M apps/shell/browser/shell_desktop_controller.h View 1 4 chunks +6 lines, -7 lines 0 comments Download
M apps/shell/browser/shell_desktop_controller.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M ash/display/display_change_observer_chromeos.h View 2 chunks +7 lines, -7 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M ash/display/display_change_observer_chromeos_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/display/display_error_observer_chromeos.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/display/display_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/display_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/display/event_transformation_handler.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M ash/display/output_configurator_animation.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/display/output_configurator_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/projecting_observer_chromeos.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/display/projecting_observer_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/projecting_observer_chromeos_unittest.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M ash/shell.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shell.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M ash/system/chromeos/power/power_event_observer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/test/shell_test_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/touch/touch_observer_hud.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/power_button_controller.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/power_button_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dbus/display_power_service_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc View 8 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/display/chromeos/display_configurator.h View 9 chunks +13 lines, -14 lines 0 comments Download
A + ui/display/chromeos/display_configurator.cc View 28 chunks +55 lines, -54 lines 0 comments Download
A + ui/display/chromeos/display_configurator_unittest.cc View 51 chunks +84 lines, -84 lines 0 comments Download
M ui/display/chromeos/native_display_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
D ui/display/chromeos/output_configurator.h View 1 chunk +0 lines, -400 lines 0 comments Download
D ui/display/chromeos/output_configurator.cc View 1 chunk +0 lines, -1058 lines 0 comments Download
D ui/display/chromeos/output_configurator_unittest.cc View 1 chunk +0 lines, -1356 lines 0 comments Download
M ui/display/chromeos/ozone/touchscreen_delegate_ozone.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/display/chromeos/ozone/touchscreen_delegate_ozone.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/display/chromeos/x11/touchscreen_delegate_x11.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/display/chromeos/x11/touchscreen_delegate_x11.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/display/display.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/display/display_unittests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
dnicoara
PTAL
6 years, 8 months ago (2014-04-04 17:56:34 UTC) #1
dnicoara
-mukai@google.com + mukai@chromium.org
6 years, 8 months ago (2014-04-04 17:57:32 UTC) #2
Jun Mukai
+oshima
6 years, 8 months ago (2014-04-04 18:10:24 UTC) #3
Jun Mukai
lgtm for chrome/browser/ui/webui/options/chromeos, chrome/browser/chromeos/display
6 years, 8 months ago (2014-04-04 18:11:30 UTC) #4
Daniel Erat
lgtm thanks! https://codereview.chromium.org/226183004/diff/1/ui/display/chromeos/display_configurator.cc File ui/display/chromeos/display_configurator.cc (right): https://codereview.chromium.org/226183004/diff/1/ui/display/chromeos/display_configurator.cc#newcode554 ui/display/chromeos/display_configurator.cc:554: native_display_delegate_->GetOutputs(); doesn't need to happen here, but ...
6 years, 8 months ago (2014-04-04 18:13:25 UTC) #5
oshima
lgtm
6 years, 8 months ago (2014-04-04 18:15:39 UTC) #6
dnicoara
https://codereview.chromium.org/226183004/diff/1/ui/display/chromeos/display_configurator.h File ui/display/chromeos/display_configurator.h (right): https://codereview.chromium.org/226183004/diff/1/ui/display/chromeos/display_configurator.h#newcode36 ui/display/chromeos/display_configurator.h:36: typedef uint64_t OutputProtectionClientId; Daniel, are you thinking to rename ...
6 years, 8 months ago (2014-04-04 18:28:59 UTC) #7
dmichael (off chromium)
pepper lgtm
6 years, 8 months ago (2014-04-04 18:58:50 UTC) #8
Daniel Erat
https://codereview.chromium.org/226183004/diff/1/ui/display/chromeos/display_configurator.h File ui/display/chromeos/display_configurator.h (right): https://codereview.chromium.org/226183004/diff/1/ui/display/chromeos/display_configurator.h#newcode36 ui/display/chromeos/display_configurator.h:36: typedef uint64_t OutputProtectionClientId; On 2014/04/04 18:28:59, dnicoara wrote: > ...
6 years, 8 months ago (2014-04-04 21:04:55 UTC) #9
dnicoara
https://codereview.chromium.org/226183004/diff/1/ui/display/chromeos/display_configurator.h File ui/display/chromeos/display_configurator.h (right): https://codereview.chromium.org/226183004/diff/1/ui/display/chromeos/display_configurator.h#newcode36 ui/display/chromeos/display_configurator.h:36: typedef uint64_t OutputProtectionClientId; On 2014/04/04 21:04:55, Daniel Erat wrote: ...
6 years, 8 months ago (2014-04-07 17:10:39 UTC) #10
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 8 months ago (2014-04-07 17:10:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/226183004/20001
6 years, 8 months ago (2014-04-07 17:11:24 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-07 18:00:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-07 18:00:36 UTC) #14
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 8 months ago (2014-04-07 18:02:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/226183004/20001
6 years, 8 months ago (2014-04-07 18:04:49 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 20:06:17 UTC) #17
Message was sent while issue was closed. 
Change committed as 262183

Powered by Google App Engine
This is Rietveld 408576698