third_party/WebKit/Source/platform/geometry/IntRect.cpp - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/IntRect.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/LengthFunctions.cpp ('k') | third_party/WebKit/Source/web/RotationViewportAnchor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/geometry/IntRect.cpp

diff --git a/third_party/WebKit/Source/platform/geometry/IntRect.cpp b/third_party/WebKit/Source/platform/geometry/IntRect.cpp

index f6fb193848f63bafd781b4fc6f5b46d3ce04665f..9431040d7010ecf57cc85c121927ed4eab60c78a 100644

--- a/third_party/WebKit/Source/platform/geometry/IntRect.cpp

+++ b/third_party/WebKit/Source/platform/geometry/IntRect.cpp

@@ -42,8 +42,8 @@ IntRect::IntRect(const FloatRect& r)

}

IntRect::IntRect(const LayoutRect& r)

- : m_location(r.x(), r.y())

- , m_size(r.width(), r.height())

+ : m_location(r.x().toInt(), r.y().toInt())

+ , m_size(r.width().toInt(), r.height().toInt())

{

}

« no previous file with comments | « third_party/WebKit/Source/platform/LengthFunctions.cpp ('k') | third_party/WebKit/Source/web/RotationViewportAnchor.cpp » ('j') | no next file with comments »