third_party/WebKit/Source/platform/LengthFunctions.cpp - Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LengthFunctions.cpp

Issue 2261663002: Disallow cast/implicit conversion from LayoutUnit to int/unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/LengthFunctions.cpp

diff --git a/third_party/WebKit/Source/platform/LengthFunctions.cpp b/third_party/WebKit/Source/platform/LengthFunctions.cpp

index 0c5dcaa03cdadc347027c7c8073f001fc8928037..b4380728e93cca4948a9bc24853bbe3f9d746cec 100644

--- a/third_party/WebKit/Source/platform/LengthFunctions.cpp

+++ b/third_party/WebKit/Source/platform/LengthFunctions.cpp

@@ -31,7 +31,7 @@ namespace blink {

int intValueForLength(const Length& length, int maximumValue)

{

- return static_cast<int>(valueForLength(length, LayoutUnit(maximumValue)));

+ return valueForLength(length, LayoutUnit(maximumValue)).toInt();

}

float floatValueForLength(const Length& length, float maximumValue)

« no previous file with comments | « third_party/WebKit/Source/platform/LayoutUnit.h ('k') | third_party/WebKit/Source/platform/geometry/IntRect.cpp » ('j') | no next file with comments »