Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: components/safe_browsing_db/v4_get_hash_protocol_manager.h

Issue 2261603002: PVer4: Re-use the PVer3 implementation to get full hashes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_check_browse_url
Patch Set: BUILD: v4_local_database_manager depends on :v4_get_hash_protocol_manager Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_get_hash_protocol_manager.h
diff --git a/components/safe_browsing_db/v4_get_hash_protocol_manager.h b/components/safe_browsing_db/v4_get_hash_protocol_manager.h
index c80f2da773f2d1489438d41e85060667c1b4f8f6..7cf003d925e70fbeb26da92016f76cd0fb478326 100644
--- a/components/safe_browsing_db/v4_get_hash_protocol_manager.h
+++ b/components/safe_browsing_db/v4_get_hash_protocol_manager.h
@@ -68,12 +68,21 @@ class V4GetHashProtocolManager : public net::URLFetcherDelegate,
// Retrieve the full hash for a set of prefixes, and invoke the callback
// argument when the results are retrieved. The callback may be invoked
- // synchronously.
+ // synchronously. Works with V3 data structures.
kcarattini 2016/08/19 03:30:56 Is this method going away eventually after the cac
virtual void GetFullHashes(const std::vector<SBPrefix>& prefixes,
const std::vector<PlatformType>& platforms,
ThreatType threat_type,
FullHashCallback callback);
+ // Retrieve the full hash for a set of prefixes, and invoke the callback
+ // argument when the results are retrieved. The callback may be invoked
+ // synchronously. Works with data types and structures for PVer4.
+ virtual void GetFullHashes(const base::hash_set<HashPrefix>& prefixes,
+ const PlatformTypeSet& platforms,
+ const ThreatEntryTypeSet& threat_entry_types,
+ const ThreatTypeSet& threat_types,
+ FullHashCallback callback);
+
// Retrieve the full hash and API metadata for a set of prefixes, and invoke
// the callback argument when the results are retrieved. The callback may be
// invoked synchronously.

Powered by Google App Engine
This is Rietveld 408576698