PVer4: Re-use the PVer3 implementation to get full hashes

components/safe_browsing_db/v4_get_hash_protocol_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_
 #define COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_
 
 // A class that implements Chrome's interface with the SafeBrowsing V4 protocol.
 //
 // The V4GetHashProtocolManager handles formatting and making requests of, and
@@ skipping 50 matching lines @@
   // Create an instance of the safe browsing v4 protocol manager.
   static V4GetHashProtocolManager* Create(
       net::URLRequestContextGetter* request_context_getter,
       const V4ProtocolConfig& config);
 
   // net::URLFetcherDelegate interface.
   void OnURLFetchComplete(const net::URLFetcher* source) override;
 
   // Retrieve the full hash for a set of prefixes, and invoke the callback
   // argument when the results are retrieved. The callback may be invoked
-  // synchronously.
+  // synchronously. Works with V3 data structures.

[kcarattini, 2016/08/19 03:30:56]

Is this method going away eventually after the caching is moved? If so, can you
add that in the comment? If not, and these structures are going to be used with
V4 going forward, then we shouldn't call them V3 structures.

   virtual void GetFullHashes(const std::vector<SBPrefix>& prefixes,
                              const std::vector<PlatformType>& platforms,
                              ThreatType threat_type,
                              FullHashCallback callback);
 
+  // Retrieve the full hash for a set of prefixes, and invoke the callback
+  // argument when the results are retrieved. The callback may be invoked
+  // synchronously. Works with data types and structures for PVer4.
+  virtual void GetFullHashes(const base::hash_set<HashPrefix>& prefixes,
+                             const PlatformTypeSet& platforms,
+                             const ThreatEntryTypeSet& threat_entry_types,
+                             const ThreatTypeSet& threat_types,
+                             FullHashCallback callback);
+
   // Retrieve the full hash and API metadata for a set of prefixes, and invoke
   // the callback argument when the results are retrieved. The callback may be
   // invoked synchronously.
   virtual void GetFullHashesWithApis(const std::vector<SBPrefix>& prefixes,

[kcarattini, 2016/08/19 03:30:56]

Does this method need to be updated too?

                                      FullHashCallback callback);
 
   // Overrides the clock used to check the time.
   void SetClockForTests(std::unique_ptr<base::Clock> clock);
 
  protected:
   // Constructs a V4GetHashProtocolManager that issues
   // network requests using |request_context_getter|.
   V4GetHashProtocolManager(net::URLRequestContextGetter* request_context_getter,
                            const V4ProtocolConfig& config);
@@ skipping 96 matching lines @@
       net::URLRequestContextGetter* request_context_getter,
       const V4ProtocolConfig& config) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(V4GetHashProtocolManagerFactory);
 };
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_