Use ScopedRTLFlipCanvas more pervasively for RTL flipping.

Use ScopedRTLFlipCanvas more pervasively for RTL flipping.

This helper already existed but was rarely used.  Now we use it in more places,
in the hopes of simpler/clearer code.

To do this, I changed the API a bit.

BUG=none
TEST=none

Committed: https://crrev.com/569dc35922520cee6ae9e874a9c4b03f3d456605
Cr-Commit-Position: refs/heads/master@{#413064}

[Peter Kasting, 2016-08-18 23:40:40]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[Peter Kasting, 2016-08-18 23:40:41]

https://codereview.chromium.org/2261593002/diff/1/chrome/browser/ui/views/dow...
File chrome/browser/ui/views/download/download_item_view.cc (right):

https://codereview.chromium.org/2261593002/diff/1/chrome/browser/ui/views/dow...
chrome/browser/ui/views/download/download_item_view.cc:708:
gfx::ScopedRTLFlipCanvas scoped_canvas(canvas, width());
This file looks as if it's changed a lot, but it's a case of the diff tool
matching up the wrong lines.  The PaintImages() calls are actually in the same
places as before.

So what's actually changed here is that the Save() call and IsRtl() conditional
are gone, and then the Restore() at the very end is gone too.  Everything else
is just indented one more level due to scoping |scoped_canvas|.

[Peter Kasting, 2016-08-19 00:05:48]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 00:06:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 00:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 00:19:43]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Peter Kasting, 2016-08-19 01:46:39]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 01:47:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 02:54:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 02:54:38]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2016-08-19 03:39:58]

Nice code savings!

[sky, 2016-08-19 03:40:02]

LGTM

[Peter Kasting, 2016-08-19 05:26:07]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-08-19 05:26:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 06:10:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-19 06:14:30]

Description was changed from

==========
Use ScopedRTLFlipCanvas more pervasively for RTL flipping.

This helper already existed but was rarely used.  Now we use it in more places,
in the hopes of simpler/clearer code.

To do this, I changed the API a bit.

BUG=none
TEST=none
==========

to

==========
Use ScopedRTLFlipCanvas more pervasively for RTL flipping.

This helper already existed but was rarely used.  Now we use it in more places,
in the hopes of simpler/clearer code.

To do this, I changed the API a bit.

BUG=none
TEST=none

Committed: https://crrev.com/569dc35922520cee6ae9e874a9c4b03f3d456605
Cr-Commit-Position: refs/heads/master@{#413064}
==========

[commit-bot: I haz the power, 2016-08-19 06:14:31]

Patchset 2 (id:??) landed as
https://crrev.com/569dc35922520cee6ae9e874a9c4b03f3d456605
Cr-Commit-Position: refs/heads/master@{#413064}