ui/gfx/scoped_canvas.cc - Issue 2261593002: Use ScopedRTLFlipCanvas more pervasively for RTL flipping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/scoped_canvas.cc

Issue 2261593002: Use ScopedRTLFlipCanvas more pervasively for RTL flipping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix namespace Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/scoped_canvas.cc

diff --git a/ui/gfx/scoped_canvas.cc b/ui/gfx/scoped_canvas.cc

index d6848e2c6e4eb7e20cc3b88a2d2e50a6a0b44d21..54d75c9a1cd7c25caac90b921a1dd22b10c5ca17 100644

--- a/ui/gfx/scoped_canvas.cc

+++ b/ui/gfx/scoped_canvas.cc

@@ -10,10 +10,11 @@

namespace gfx {

ScopedRTLFlipCanvas::ScopedRTLFlipCanvas(gfx::Canvas* canvas,

- const gfx::Rect& rect)

+ int width,

+ bool flip)

: canvas_(canvas) {

- if (base::i18n::IsRTL()) {

- canvas->Translate(gfx::Vector2d(rect.width(), 0));

+ if (flip && base::i18n::IsRTL()) {

+ canvas->Translate(gfx::Vector2d(width, 0));

canvas->Scale(-1, 1);

}

« no previous file with comments | « ui/gfx/scoped_canvas.h ('k') | ui/views/controls/combobox/combobox.cc » ('j') | no next file with comments »