chrome/browser/plugins/plugin_observer.cc - Issue 2261533003: Provide a callback for Component Updater OnDemand calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_observer.cc

Issue 2261533003: Provide a callback for Component Updater OnDemand calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix for cast Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc ('k') | chrome/browser/ui/webui/components_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugins/plugin_observer.cc

diff --git a/chrome/browser/plugins/plugin_observer.cc b/chrome/browser/plugins/plugin_observer.cc

index 2494c3843cf9c1982eaf6ff91c937f4bd6f07eaa..44aac14c052575da14b8c02c8b0449ec5d0f1dd3 100644

--- a/chrome/browser/plugins/plugin_observer.cc

+++ b/chrome/browser/plugins/plugin_observer.cc

@@ -417,7 +417,8 @@ void PluginObserver::OnBlockedComponentUpdatedPlugin(

component_observers_[placeholder_id] =

base::MakeUnique<ComponentObserver>(this, placeholder_id, identifier);

g_browser_process->component_updater()->GetOnDemandUpdater().OnDemandUpdate(

- identifier);

+ identifier,

+ component_updater::ComponentUpdateService::CompletionCallback());

}

void PluginObserver::RemoveComponentObserver(int placeholder_id) {