chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc - Issue 2261533003: Provide a callback for Component Updater OnDemand calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

Issue 2261533003: Provide a callback for Component Updater OnDemand calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix for cast Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/supervised_user_whitelist_installer.cc ('k') | chrome/browser/plugins/plugin_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

diff --git a/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc b/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

index bd2b73d3bc1b501e939944deb2fbd53a920a7679..8c76c09ddfca4da5ce8f9b7dd5efe8ee103ce9bc 100644

--- a/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

+++ b/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

@@ -142,16 +142,17 @@ class MockComponentUpdateService : public ComponentUpdateService,

}

// OnDemandUpdater implementation:

- bool OnDemandUpdate(const std::string& crx_id) override {

+ void OnDemandUpdate(

+ const std::string& crx_id,

+ ComponentUpdateService::CompletionCallback callback) override {

on_demand_update_called_ = true;

if (!component_) {

ADD_FAILURE() << "Trying to update unregistered component " << crx_id;

- return false;

+ return;

}

EXPECT_EQ(GetCrxComponentID(*component_), crx_id);

- return true;

}

private: