Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: chrome/browser/component_updater/supervised_user_whitelist_installer.cc

Issue 2261533003: Provide a callback for Component Updater OnDemand calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix for cast Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/supervised_user_whitelist_installer.cc
diff --git a/chrome/browser/component_updater/supervised_user_whitelist_installer.cc b/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
index ef24cd25d1b07b876c31ea0f6964c52e7761c766..6290a74cf5353fad43ef2baeae4300601d8c01c9 100644
--- a/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
+++ b/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
@@ -642,8 +642,8 @@ std::vector<uint8_t> SupervisedUserWhitelistInstaller::GetHashFromCrxId(
void SupervisedUserWhitelistInstaller::TriggerComponentUpdate(
OnDemandUpdater* updater,
const std::string& crx_id) {
- const bool result = updater->OnDemandUpdate(crx_id);
- DCHECK(result);
+ // TODO(sorin): use a callback to check the result (crbug.com/639189).
+ updater->OnDemandUpdate(crx_id, ComponentUpdateService::CompletionCallback());
}
} // namespace component_updater
« no previous file with comments | « no previous file | chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698