Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2261513003: Revert of [heap] Improve size profiling for ArrayBuffer tracking (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Improve size profiling for ArrayBuffer tracking (patchset #6 id:140001 of https://codereview.chromium.org/2210263002/ ) Reason for revert: Tanks octane Original issue's description: > [heap] Improve size profiling for ArrayBuffer tracking > > Eagerly account for retained sizes during ArrayBuffer tracking. Following up on this, > we can now do Scavenges if the amount of memory retained from new space is too large. > > BUG=chromium:621829 > R=jochen@chromium.org,hpayer@chromium.org > > Committed: https://crrev.com/28e13bd6a75c9467dae43043e7b741a1387d5252 > Cr-Commit-Position: refs/heads/master@{#38731} TBR=jochen@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:621829 Committed: https://crrev.com/fbf1bc66c46f9ad5412ea5dfed42a56d4284922f Cr-Commit-Position: refs/heads/master@{#38739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -237 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 3 chunks +13 lines, -44 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 6 chunks +43 lines, -74 lines 0 comments Download
M src/heap/array-buffer-tracker-inl.h View 3 chunks +4 lines, -14 lines 0 comments Download
M src/heap/heap.h View 4 chunks +11 lines, -8 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +4 lines, -25 lines 0 comments Download
M src/heap/mark-compact.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/heap/test-array-buffer-tracker.cc View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Lippautz
Created Revert of [heap] Improve size profiling for ArrayBuffer tracking
4 years, 4 months ago (2016-08-19 08:16:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261513003/1
4 years, 4 months ago (2016-08-19 08:17:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 08:17:14 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 08:17:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbf1bc66c46f9ad5412ea5dfed42a56d4284922f
Cr-Commit-Position: refs/heads/master@{#38739}

Powered by Google App Engine
This is Rietveld 408576698