Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: src/heap/mark-compact.cc

Issue 2261513003: Revert of [heap] Improve size profiling for ArrayBuffer tracking (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index 74d03b3884f92e09b5cc238be8350de895c502d8..c7e4d8f29a6cd9c60f1882bb945f0be518a6f256 100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -833,7 +833,7 @@
space = spaces.next()) {
space->PrepareForMarkCompact();
}
- heap()->array_buffer_tracker()->AccountForConcurrentlyFreedMemory();
+ heap()->account_external_memory_concurrently_freed();
#ifdef VERIFY_HEAP
if (!was_marked_incrementally_ && FLAG_verify_heap) {
@@ -3132,8 +3132,7 @@
case kObjectsNewToOld:
success = collector_->VisitLiveObjects(page, &new_space_visitor_,
kClearMarkbits);
-
- heap->array_buffer_tracker()->ProcessBuffers(
+ ArrayBufferTracker::ProcessBuffers(
page, ArrayBufferTracker::kUpdateForwardedRemoveOthers);
DCHECK(success);
break;
@@ -3160,14 +3159,14 @@
EvacuateRecordOnlyVisitor record_visitor(collector_->heap());
success =
collector_->VisitLiveObjects(page, &record_visitor, kKeepMarking);
- heap->array_buffer_tracker()->ProcessBuffers(
+ ArrayBufferTracker::ProcessBuffers(
page, ArrayBufferTracker::kUpdateForwardedKeepOthers);
DCHECK(success);
// We need to return failure here to indicate that we want this page
// added to the sweeper.
success = false;
} else {
- heap->array_buffer_tracker()->ProcessBuffers(
+ ArrayBufferTracker::ProcessBuffers(
page, ArrayBufferTracker::kUpdateForwardedRemoveOthers);
}
break;
@@ -3371,7 +3370,7 @@
// Before we sweep objects on the page, we free dead array buffers which
// requires valid mark bits.
- p->heap()->array_buffer_tracker()->FreeDead(p);
+ ArrayBufferTracker::FreeDead(p);
Address free_start = p->area_start();
DCHECK(reinterpret_cast<intptr_t>(free_start) % (32 * kPointerSize) == 0);
@@ -3938,7 +3937,7 @@
PrintIsolate(isolate(), "sweeping: released page: %p",
static_cast<void*>(p));
}
- heap()->array_buffer_tracker()->FreeAll(p);
+ ArrayBufferTracker::FreeAll(p);
space->ReleasePage(p);
continue;
}
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/spaces.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698