Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2261443002: Replace SMILTime with double for elapsed time in SMILTimeContainer (Closed)

Created:
4 years, 4 months ago by fs
Modified:
4 years, 4 months ago
Reviewers:
pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@smilcontainer-canscheduleframe-pred
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace SMILTime with double for elapsed time in SMILTimeContainer We don't really make use of of the special properties of SMILTime for this case, and using double means slightly less impedance mismatching. BUG=631879 Committed: https://crrev.com/a7db22cfba4e58f6335d3e61193018e93164f53b Cr-Commit-Position: refs/heads/master@{#413345}

Patch Set 1 #

Patch Set 2 : REbase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 1 11 chunks +16 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (13 generated)
fs
4 years, 4 months ago (2016-08-19 13:26:08 UTC) #8
pdr.
On 2016/08/19 at 13:26:08, fs wrote: > LGTM
4 years, 4 months ago (2016-08-19 21:42:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261443002/20001
4 years, 4 months ago (2016-08-20 16:24:39 UTC) #13
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-20 17:34:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261443002/20001
4 years, 4 months ago (2016-08-20 17:56:45 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-20 18:29:50 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 18:31:23 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7db22cfba4e58f6335d3e61193018e93164f53b
Cr-Commit-Position: refs/heads/master@{#413345}

Powered by Google App Engine
This is Rietveld 408576698