Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 2257803002: Refactor SMILTimeContainer can-schedule-frame predicate (Closed)

Created:
4 years, 4 months ago by fs
Modified:
4 years, 4 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@smilcontainer-timeline-cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor SMILTimeContainer can-schedule-frame predicate begin() and updateAnimationsAndScheduleFrameIfNeeded() use the same predicate to check if they should schedule an animation frame - although they phrase it slightly differently (because of local knowledge.) Move the generic version to a canScheduleFrame() method and use that in both cases. BUG=631879 Committed: https://crrev.com/ebd6dde89d88e789ecc2751668506910acba165a Cr-Commit-Position: refs/heads/master@{#413328}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 1 2 chunks +13 lines, -24 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
fs
4 years, 4 months ago (2016-08-19 13:25:46 UTC) #10
pdr.
On 2016/08/19 at 13:25:46, fs wrote: > LGTM Touching the animation system frequently leads to ...
4 years, 4 months ago (2016-08-19 21:41:13 UTC) #11
fs
On 2016/08/19 at 21:41:13, pdr wrote: > On 2016/08/19 at 13:25:46, fs wrote: > > ...
4 years, 4 months ago (2016-08-20 08:53:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257803002/20001
4 years, 4 months ago (2016-08-20 08:54:12 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-20 08:59:05 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 09:00:49 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebd6dde89d88e789ecc2751668506910acba165a
Cr-Commit-Position: refs/heads/master@{#413328}

Powered by Google App Engine
This is Rietveld 408576698