Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2261313002: [Extensions] Convert some SyncExtensionFunctions (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some SyncExtensionFunctions SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove SyncExtensionFunctions from: - management - metrics_private - system_private - networking_private - power BUG=634140 Committed: https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a Cr-Commit-Position: refs/heads/master@{#414284}

Patch Set 1 : ready #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -211 lines) Patch
M chrome/browser/extensions/api/management/chrome_management_api_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/chrome_management_api_delegate.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_private_api.h View 14 chunks +26 lines, -22 lines 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_private_api.cc View 3 chunks +59 lines, -46 lines 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_api.h View 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_api.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M extensions/browser/api/management/management_api.h View 9 chunks +13 lines, -17 lines 0 comments Download
M extensions/browser/api/management/management_api.cc View 9 chunks +33 lines, -54 lines 0 comments Download
M extensions/browser/api/management/management_api_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_api.h View 9 chunks +16 lines, -15 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_api.cc View 6 chunks +29 lines, -22 lines 0 comments Download
M extensions/browser/api/power/power_api.h View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/power/power_api.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
Devlin
Antony, can you take a look?
4 years, 3 months ago (2016-08-23 22:05:00 UTC) #14
asargent_no_longer_on_chrome
lgtm
4 years, 3 months ago (2016-08-24 19:54:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261313002/40001
4 years, 3 months ago (2016-08-25 00:29:05 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/267142)
4 years, 3 months ago (2016-08-25 01:34:38 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261313002/40001
4 years, 3 months ago (2016-08-25 01:41:19 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-08-25 03:15:30 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 03:17:24 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c448a7d036621333de42066bd5a8a06982ad87a
Cr-Commit-Position: refs/heads/master@{#414284}

Powered by Google App Engine
This is Rietveld 408576698