Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: chrome/browser/extensions/api/metrics_private/metrics_private_api.h

Issue 2261313002: [Extensions] Convert some SyncExtensionFunctions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ready Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_METRICS_PRIVATE_METRICS_PRIVATE_API_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_METRICS_PRIVATE_METRICS_PRIVATE_API_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_METRICS_PRIVATE_METRICS_PRIVATE_API_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_METRICS_PRIVATE_METRICS_PRIVATE_API_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
11 11
12 #include "base/metrics/histogram.h" 12 #include "base/metrics/histogram.h"
13 #include "extensions/browser/extension_function.h" 13 #include "extensions/browser/extension_function.h"
14 14
15 namespace extensions { 15 namespace extensions {
16 16
17 class MetricsPrivateGetIsCrashReportingEnabledFunction 17 class MetricsPrivateGetIsCrashReportingEnabledFunction
18 : public SyncExtensionFunction { 18 : public UIThreadExtensionFunction {
19 public: 19 public:
20 DECLARE_EXTENSION_FUNCTION("metricsPrivate.getIsCrashReportingEnabled", 20 DECLARE_EXTENSION_FUNCTION("metricsPrivate.getIsCrashReportingEnabled",
21 METRICSPRIVATE_GETISCRASHRECORDINGENABLED) 21 METRICSPRIVATE_GETISCRASHRECORDINGENABLED)
22 22
23 protected: 23 protected:
24 ~MetricsPrivateGetIsCrashReportingEnabledFunction() override {} 24 ~MetricsPrivateGetIsCrashReportingEnabledFunction() override {}
25 25
26 // ExtensionFunction: 26 // ExtensionFunction:
27 bool RunSync() override; 27 ResponseAction Run() override;
28 }; 28 };
29 29
30 class MetricsPrivateGetFieldTrialFunction : public SyncExtensionFunction { 30 class MetricsPrivateGetFieldTrialFunction : public UIThreadExtensionFunction {
31 public: 31 public:
32 DECLARE_EXTENSION_FUNCTION("metricsPrivate.getFieldTrial", 32 DECLARE_EXTENSION_FUNCTION("metricsPrivate.getFieldTrial",
33 METRICSPRIVATE_GETFIELDTRIAL) 33 METRICSPRIVATE_GETFIELDTRIAL)
34 34
35 protected: 35 protected:
36 ~MetricsPrivateGetFieldTrialFunction() override {} 36 ~MetricsPrivateGetFieldTrialFunction() override {}
37 37
38 // ExtensionFunction: 38 // ExtensionFunction:
39 bool RunSync() override; 39 ResponseAction Run() override;
40 }; 40 };
41 41
42 class MetricsPrivateGetVariationParamsFunction : public SyncExtensionFunction { 42 class MetricsPrivateGetVariationParamsFunction
43 : public UIThreadExtensionFunction {
43 public: 44 public:
44 DECLARE_EXTENSION_FUNCTION("metricsPrivate.getVariationParams", 45 DECLARE_EXTENSION_FUNCTION("metricsPrivate.getVariationParams",
45 METRICSPRIVATE_GETVARIATIONPARAMS) 46 METRICSPRIVATE_GETVARIATIONPARAMS)
46 47
47 protected: 48 protected:
48 ~MetricsPrivateGetVariationParamsFunction() override {} 49 ~MetricsPrivateGetVariationParamsFunction() override {}
49 50
50 // ExtensionFunction: 51 // ExtensionFunction:
51 bool RunSync() override; 52 ResponseAction Run() override;
52 }; 53 };
53 54
54 class MetricsPrivateRecordUserActionFunction : public SyncExtensionFunction { 55 class MetricsPrivateRecordUserActionFunction
56 : public UIThreadExtensionFunction {
55 public: 57 public:
56 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordUserAction", 58 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordUserAction",
57 METRICSPRIVATE_RECORDUSERACTION) 59 METRICSPRIVATE_RECORDUSERACTION)
58 60
59 protected: 61 protected:
60 ~MetricsPrivateRecordUserActionFunction() override {} 62 ~MetricsPrivateRecordUserActionFunction() override {}
61 63
62 // ExtensionFunction: 64 // ExtensionFunction:
63 bool RunSync() override; 65 ResponseAction Run() override;
64 }; 66 };
65 67
66 class MetricsHistogramHelperFunction : public SyncExtensionFunction { 68 class MetricsHistogramHelperFunction : public UIThreadExtensionFunction {
67 protected: 69 protected:
68 ~MetricsHistogramHelperFunction() override {} 70 ~MetricsHistogramHelperFunction() override {}
69 virtual bool RecordValue(const std::string& name, 71 void RecordValue(const std::string& name,
70 base::HistogramType type, 72 base::HistogramType type,
71 int min, int max, size_t buckets, 73 int min,
72 int sample); 74 int max,
75 size_t buckets,
76 int sample);
73 }; 77 };
74 78
75 class MetricsPrivateRecordValueFunction 79 class MetricsPrivateRecordValueFunction
76 : public MetricsHistogramHelperFunction { 80 : public MetricsHistogramHelperFunction {
77 public: 81 public:
78 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordValue", 82 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordValue",
79 METRICSPRIVATE_RECORDVALUE) 83 METRICSPRIVATE_RECORDVALUE)
80 84
81 protected: 85 protected:
82 ~MetricsPrivateRecordValueFunction() override {} 86 ~MetricsPrivateRecordValueFunction() override {}
83 87
84 // ExtensionFunction: 88 // ExtensionFunction:
85 bool RunSync() override; 89 ResponseAction Run() override;
86 }; 90 };
87 91
88 class MetricsPrivateRecordSparseValueFunction 92 class MetricsPrivateRecordSparseValueFunction
89 : public MetricsHistogramHelperFunction { 93 : public MetricsHistogramHelperFunction {
90 public: 94 public:
91 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordSparseValue", 95 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordSparseValue",
92 METRICSPRIVATE_RECORDSPARSEVALUE) 96 METRICSPRIVATE_RECORDSPARSEVALUE)
93 97
94 protected: 98 protected:
95 ~MetricsPrivateRecordSparseValueFunction() override {} 99 ~MetricsPrivateRecordSparseValueFunction() override {}
96 100
97 // ExtensionFunction: 101 // ExtensionFunction:
98 bool RunSync() override; 102 ResponseAction Run() override;
99 }; 103 };
100 104
101 class MetricsPrivateRecordPercentageFunction 105 class MetricsPrivateRecordPercentageFunction
102 : public MetricsHistogramHelperFunction { 106 : public MetricsHistogramHelperFunction {
103 public: 107 public:
104 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordPercentage", 108 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordPercentage",
105 METRICSPRIVATE_RECORDPERCENTAGE) 109 METRICSPRIVATE_RECORDPERCENTAGE)
106 110
107 protected: 111 protected:
108 ~MetricsPrivateRecordPercentageFunction() override {} 112 ~MetricsPrivateRecordPercentageFunction() override {}
109 113
110 // ExtensionFunction: 114 // ExtensionFunction:
111 bool RunSync() override; 115 ResponseAction Run() override;
112 }; 116 };
113 117
114 class MetricsPrivateRecordCountFunction 118 class MetricsPrivateRecordCountFunction
115 : public MetricsHistogramHelperFunction { 119 : public MetricsHistogramHelperFunction {
116 public: 120 public:
117 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordCount", 121 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordCount",
118 METRICSPRIVATE_RECORDCOUNT) 122 METRICSPRIVATE_RECORDCOUNT)
119 123
120 protected: 124 protected:
121 ~MetricsPrivateRecordCountFunction() override {} 125 ~MetricsPrivateRecordCountFunction() override {}
122 126
123 // ExtensionFunction: 127 // ExtensionFunction:
124 bool RunSync() override; 128 ResponseAction Run() override;
125 }; 129 };
126 130
127 class MetricsPrivateRecordSmallCountFunction 131 class MetricsPrivateRecordSmallCountFunction
128 : public MetricsHistogramHelperFunction { 132 : public MetricsHistogramHelperFunction {
129 public: 133 public:
130 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordSmallCount", 134 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordSmallCount",
131 METRICSPRIVATE_RECORDSMALLCOUNT) 135 METRICSPRIVATE_RECORDSMALLCOUNT)
132 136
133 protected: 137 protected:
134 ~MetricsPrivateRecordSmallCountFunction() override {} 138 ~MetricsPrivateRecordSmallCountFunction() override {}
135 139
136 // ExtensionFunction: 140 // ExtensionFunction:
137 bool RunSync() override; 141 ResponseAction Run() override;
138 }; 142 };
139 143
140 class MetricsPrivateRecordMediumCountFunction 144 class MetricsPrivateRecordMediumCountFunction
141 : public MetricsHistogramHelperFunction { 145 : public MetricsHistogramHelperFunction {
142 public: 146 public:
143 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordMediumCount", 147 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordMediumCount",
144 METRICSPRIVATE_RECORDMEDIUMCOUNT) 148 METRICSPRIVATE_RECORDMEDIUMCOUNT)
145 149
146 protected: 150 protected:
147 ~MetricsPrivateRecordMediumCountFunction() override {} 151 ~MetricsPrivateRecordMediumCountFunction() override {}
148 152
149 // ExtensionFunction: 153 // ExtensionFunction:
150 bool RunSync() override; 154 ResponseAction Run() override;
151 }; 155 };
152 156
153 class MetricsPrivateRecordTimeFunction : public MetricsHistogramHelperFunction { 157 class MetricsPrivateRecordTimeFunction : public MetricsHistogramHelperFunction {
154 public: 158 public:
155 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordTime", 159 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordTime",
156 METRICSPRIVATE_RECORDTIME) 160 METRICSPRIVATE_RECORDTIME)
157 161
158 protected: 162 protected:
159 ~MetricsPrivateRecordTimeFunction() override {} 163 ~MetricsPrivateRecordTimeFunction() override {}
160 164
161 // ExtensionFunction: 165 // ExtensionFunction:
162 bool RunSync() override; 166 ResponseAction Run() override;
163 }; 167 };
164 168
165 class MetricsPrivateRecordMediumTimeFunction 169 class MetricsPrivateRecordMediumTimeFunction
166 : public MetricsHistogramHelperFunction { 170 : public MetricsHistogramHelperFunction {
167 public: 171 public:
168 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordMediumTime", 172 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordMediumTime",
169 METRICSPRIVATE_RECORDMEDIUMTIME) 173 METRICSPRIVATE_RECORDMEDIUMTIME)
170 174
171 protected: 175 protected:
172 ~MetricsPrivateRecordMediumTimeFunction() override {} 176 ~MetricsPrivateRecordMediumTimeFunction() override {}
173 177
174 // ExtensionFunction: 178 // ExtensionFunction:
175 bool RunSync() override; 179 ResponseAction Run() override;
176 }; 180 };
177 181
178 class MetricsPrivateRecordLongTimeFunction 182 class MetricsPrivateRecordLongTimeFunction
179 : public MetricsHistogramHelperFunction { 183 : public MetricsHistogramHelperFunction {
180 public: 184 public:
181 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordLongTime", 185 DECLARE_EXTENSION_FUNCTION("metricsPrivate.recordLongTime",
182 METRICSPRIVATE_RECORDLONGTIME) 186 METRICSPRIVATE_RECORDLONGTIME)
183 187
184 protected: 188 protected:
185 ~MetricsPrivateRecordLongTimeFunction() override {} 189 ~MetricsPrivateRecordLongTimeFunction() override {}
186 190
187 // ExtensionFunction: 191 // ExtensionFunction:
188 bool RunSync() override; 192 ResponseAction Run() override;
189 }; 193 };
190 194
191 } // namespace extensions 195 } // namespace extensions
192 196
193 #endif // CHROME_BROWSER_EXTENSIONS_API_METRICS_PRIVATE_METRICS_PRIVATE_API_H_ 197 #endif // CHROME_BROWSER_EXTENSIONS_API_METRICS_PRIVATE_METRICS_PRIVATE_API_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698