third_party/WebKit/Source/modules/notifications/NotificationData.cpp - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/notifications/notification_message_filter.cc ('K') | « third_party/WebKit/Source/modules/notifications/Notification.idl ('k') | third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp » ('j') | third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

index 572970a51b3ec1dff40b56ff9b6c38e62261c21e..bb81e311e361b18b3080c21f6bd376a5a9ebff5b 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

@@ -59,6 +59,9 @@ WebNotificationData createWebNotificationData(ExecutionContext* executionContext

webData.body = options.body();

webData.tag = options.tag();

+ if (options.hasImage() && !options.image().isEmpty())

+ webData.image = completeURL(executionContext, options.image());

if (options.hasIcon() && !options.icon().isEmpty())

webData.icon = completeURL(executionContext, options.icon());