Issue 2261243003: [Sync] Fix account id comparison for cookie jar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2261243003: [Sync] Fix account id comparison for cookie jar (Closed)

Created:
4 years, 4 months ago by Nicolas Zea

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

[Sync] Fix account id comparison for cookie jar Gaia ID != Account ID in all cases. |id| is the proper variable to use. BUG=639335 Review-Url: https://codereview.chromium.org/2266483002 Cr-Commit-Position: refs/heads/master@{#413210} (cherry picked from commit 5ca485b1159f942c41fa94978c3ba672928eb939) Committed: https://chromium.googlesource.com/chromium/src/+/ecb67345d631b774b949bdfce08c8a3f41bdd799

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	components/browser_sync/browser/profile_sync_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Nicolas Zea

4 years, 4 months ago (2016-08-22 18:37:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ecb67345d631b774b949bdfce08c8a3f41bdd799.