Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2266483002: [Sync] Fix account id comparison for cookie jar (Closed)

Created:
4 years, 4 months ago by Nicolas Zea
Modified:
4 years, 4 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix account id comparison for cookie jar Gaia ID != Account ID in all cases. |id| is the proper variable to use. BUG=639335 Committed: https://crrev.com/5ca485b1159f942c41fa94978c3ba672928eb939 Cr-Commit-Position: refs/heads/master@{#413210}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Nicolas Zea
PTAL
4 years, 4 months ago (2016-08-19 18:16:37 UTC) #8
skym
lgtm
4 years, 4 months ago (2016-08-19 18:44:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266483002/20001
4 years, 4 months ago (2016-08-19 19:22:09 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 19:26:35 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 19:29:24 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ca485b1159f942c41fa94978c3ba672928eb939
Cr-Commit-Position: refs/heads/master@{#413210}

Powered by Google App Engine
This is Rietveld 408576698