Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226123004: Get rid of all component builds specific .isolate. (Closed)

Created:
6 years, 8 months ago by M-A Ruel
Modified:
6 years, 8 months ago
Reviewers:
csharp
CC:
chromium-reviews, cbentzel+watch_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org, Ken Russell (switch to Gerrit), Vadim Sh.
Visibility:
Public.

Description

Get rid of all component builds specific .isolate. The status quo was unmaintainable. These 'component build specific .isolate files' are superseeded by tools/isolate_driver.py which packages dynamic libraries automatically. The new way is much more sane and dynamic, isolate_driver.py is currently very crude but 'does the job', the expected way to make it work is to read the .ninja files to extract all the dynamic libraries marked as a dependency to the main target being executed. TBR=csharp@chromium.org BUG=333473 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261871

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -357 lines) Patch
M base/base.isolate View 1 chunk +0 lines, -43 lines 0 comments Download
D base/base_prefs.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
M base/base_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
D build/linux/system.isolate View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/unit_tests.isolate View 1 chunk +1 line, -1 line 3 comments Download
D crypto/crypto.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
M mojo/mojo_apps_js_unittests.isolate View 3 chunks +0 lines, -42 lines 0 comments Download
M mojo/mojo_js_unittests.isolate View 3 chunks +0 lines, -36 lines 0 comments Download
M net/net.isolate View 1 chunk +0 lines, -29 lines 0 comments Download
M net/net_unittests.isolate View 1 chunk +1 line, -8 lines 0 comments Download
D net/third_party/nss/ssl.isolate View 1 chunk +0 lines, -24 lines 0 comments Download
D net/third_party/nss/ssl_base.isolate View 1 chunk +0 lines, -16 lines 0 comments Download
D net/v8.isolate View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/nss.isolate View 1 chunk +0 lines, -31 lines 0 comments Download
D url/url.isolate View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
M-A Ruel
That's 355 lines gone Jim. I only tested locally with base_unittests_run on linux. Will test ...
6 years, 8 months ago (2014-04-04 15:34:19 UTC) #1
M-A Ruel
On 2014/04/04 15:34:19, M-A Ruel wrote: > That's 355 lines gone Jim. > > I ...
6 years, 8 months ago (2014-04-04 15:46:29 UTC) #2
csharp
https://codereview.chromium.org/226123004/diff/1/chrome/unit_tests.isolate File chrome/unit_tests.isolate (left): https://codereview.chromium.org/226123004/diff/1/chrome/unit_tests.isolate#oldcode125 chrome/unit_tests.isolate:125: '../third_party/icu/icu.isolate', I don't see icu.isolate getting modified in this ...
6 years, 8 months ago (2014-04-04 17:17:10 UTC) #3
M-A Ruel
https://codereview.chromium.org/226123004/diff/1/chrome/unit_tests.isolate File chrome/unit_tests.isolate (left): https://codereview.chromium.org/226123004/diff/1/chrome/unit_tests.isolate#oldcode125 chrome/unit_tests.isolate:125: '../third_party/icu/icu.isolate', On 2014/04/04 17:17:10, csharp wrote: > I don't ...
6 years, 8 months ago (2014-04-04 17:20:51 UTC) #4
csharp
lgtm https://codereview.chromium.org/226123004/diff/1/chrome/unit_tests.isolate File chrome/unit_tests.isolate (left): https://codereview.chromium.org/226123004/diff/1/chrome/unit_tests.isolate#oldcode125 chrome/unit_tests.isolate:125: '../third_party/icu/icu.isolate', On 2014/04/04 17:20:51, M-A Ruel wrote: > ...
6 years, 8 months ago (2014-04-04 17:27:34 UTC) #5
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 8 months ago (2014-04-04 17:32:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/226123004/1
6 years, 8 months ago (2014-04-04 17:33:01 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 18:22:48 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=59649
6 years, 8 months ago (2014-04-04 18:22:49 UTC) #9
M-A Ruel
On 2014/04/04 18:22:49, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 8 months ago (2014-04-04 18:27:42 UTC) #10
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 8 months ago (2014-04-04 18:27:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/226123004/1
6 years, 8 months ago (2014-04-04 18:27:58 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 21:06:53 UTC) #13
Message was sent while issue was closed. 
Change committed as 261871

Powered by Google App Engine
This is Rietveld 408576698