Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: base/base.isolate

Issue 226123004: Get rid of all component builds specific .isolate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base_prefs.isolate » ('j') | chrome/unit_tests.isolate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.isolate
diff --git a/base/base.isolate b/base/base.isolate
index bfa81fe760df26edc4a8709501c16c4c51f295ca..442d168ca4112c10303531391cfba583e6bd1f4b 100644
--- a/base/base.isolate
+++ b/base/base.isolate
@@ -2,50 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
- 'conditions': [
- ['OS=="linux" and component=="shared_library"', {
- 'variables': {
- 'isolate_dependency_tracked': [
- '<(PRODUCT_DIR)/lib/libbase.so',
- '<(PRODUCT_DIR)/lib/libbase_i18n.so',
- ],
- },
- }],
- ['OS=="mac" and component=="shared_library"', {
- 'variables': {
- 'isolate_dependency_tracked': [
- '<(PRODUCT_DIR)/libbase.dylib',
- '<(PRODUCT_DIR)/libbase_i18n.dylib',
- ],
- },
- }],
- ['OS=="win" and component=="shared_library"', {
- 'variables': {
- 'isolate_dependency_tracked': [
- '<(PRODUCT_DIR)/base.dll',
- '<(PRODUCT_DIR)/base_i18n.dll',
- ],
- },
- }],
- ],
- # Important note:
- # Running:
- # 1. GYP_DEFINES=component=shared_library build/gyp_chromium
- # 2. ninja -C out/Debug base
- # will result with only libbase.so being built. Building base by itself won't
- # force the build of icu or nss. This is because base is not usable by itself.
- # But on the other hand any test that includes base will be building and
- # loading at runtime both icu and nss. So define here what is brought by
- # importing base, not what base would load at runtime.
- #
- # There is no such thing as direct_dependent in .isolate, so it's not the best
- # format to describe this kind of thing. But as a user of base.so, the user
- # will be importing these other libraries:
'includes': [
- # While the target 'base' doesn't depend on ../build/linux/system.gyp:ssl
- # itself, virtually all targets using it has to include
- # ../third_party/nss/ssl.gyp:libssl through system.gyp.
- '../build/linux/system.isolate',
# While the target 'base' doesn't depend on ../third_party/icu/icu.gyp
# itself, virtually all targets using it has to include icu. The only
# exception is the Windows sandbox (?).
« no previous file with comments | « no previous file | base/base_prefs.isolate » ('j') | chrome/unit_tests.isolate » ('J')

Powered by Google App Engine
This is Rietveld 408576698