Issue 22612003: Warn when extensions suggest conflicting download filenames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22612003: Warn when extensions suggest conflicting download filenames (Closed)

Created:
7 years, 4 months ago by benjhayden

Modified:
7 years, 4 months ago

Reviewers:
scheib, asargent_no_longer_on_chrome

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+195 lines, -7 lines)			Patch
M	chrome/browser/extensions/api/downloads/downloads_api.h	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/downloads/downloads_api.cc	View	14 chunks	+78 lines, -7 lines	0 comments	Download
M	chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc	View	1 chunk	+70 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_warning_set.h	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_warning_set.cc	View	2 chunks	+19 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

benjhayden

7 years, 4 months ago (2013-08-10 18:14:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r216882 (presubmit successful).