Warn when extensions suggest conflicting download filenames

chrome/browser/extensions/extension_warning_set.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_warning_set.h"
 
+#include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "content/public/browser/browser_thread.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "net/base/escape.h"
 #include "ui/base/l10n/l10n_util.h"
 
@@ skipping 133 matching lines @@
     const std::string& extension_id) {
   std::vector<std::string> message_parameters;
   message_parameters.push_back(l10n_util::GetStringUTF8(IDS_PRODUCT_NAME));
   return ExtensionWarning(
       kRepeatedCacheFlushes,
       extension_id,
       IDS_EXTENSION_WARNINGS_NETWORK_DELAY,
       message_parameters);
 }
 
+// static
+ExtensionWarning ExtensionWarning::CreateDownloadFilenameConflictWarning(
+    const std::string& losing_extension_id,
+    const std::string& winning_extension_id,
+    const base::FilePath& losing_filename,
+    const base::FilePath& winning_filename) {
+  std::vector<std::string> message_parameters;
+  message_parameters.push_back(UTF16ToUTF8(losing_filename.LossyDisplayName()));
+  message_parameters.push_back(kTranslate + winning_extension_id);
+  message_parameters.push_back(UTF16ToUTF8(
+      winning_filename.LossyDisplayName()));
+  return ExtensionWarning(
+      kDownloadFilenameConflict,
+      losing_extension_id,
+      IDS_EXTENSION_WARNINGS_DOWNLOAD_FILENAME_CONFLICT,
+      message_parameters);
+}
+
 std::string ExtensionWarning::GetLocalizedMessage(
     const ExtensionSet* extensions) const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   // These parameters may be unsafe (URLs and Extension names) and need
   // to be HTML-escaped before being embedded in the UI. Also extension IDs
   // are translated to full extension names.
   std::vector<string16> final_parameters;
   for (size_t i = 0; i < message_parameters_.size(); ++i) {
     std::string message = message_parameters_[i];
@@ skipping 27 matching lines @@
   }
 }
 
 bool operator<(const ExtensionWarning& a, const ExtensionWarning& b) {
   if (a.extension_id() != b.extension_id())
     return a.extension_id() < b.extension_id();
   return a.warning_type() < b.warning_type();
 }
 
 }  // namespace extensions