Issue 2261183004: Revert "simplify build sdk"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2261183004: Revert "simplify build sdk" (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly

Modified:
4 years, 4 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "simplify build sdk" This reverts commit 4cf8eebec783fbc3ac8e027bf5a64b5bf2178ad3. apparently we use it for code coverage. go figure. Committed: https://github.com/dart-lang/dev_compiler/commit/d360900099c96c26eb5327ed7585499c207629cf

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -30 lines)			Patch
	A	tool/build_sdk.dart	View		1 chunk	+52 lines, -0 lines	0 comments	Download
	M	tool/build_sdk.sh	View		1 chunk	+8 lines, -30 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

Committed patchset #1 (id:1) manually as d360900099c96c26eb5327ed7585499c207629cf (presubmit successful).

4 years, 4 months ago (2016-08-22 20:11:49 UTC) #2

Jennifer Messerly

TBR, sorry about that. I missed the comment at the top of the file.

4 years, 4 months ago (2016-08-22 20:12:20 UTC) #4

vsm

4 years, 4 months ago (2016-08-22 20:21:21 UTC) #5

Message was sent while issue was closed.

On 2016/08/22 20:12:20, John Messerly wrote:
> TBR, sorry about that. I missed the comment at the top of the file.

doh!

lgtm