Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tool/build_sdk.sh

Issue 2261183004: Revert "simplify build sdk" (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tool/build_sdk.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/build_sdk.sh
diff --git a/tool/build_sdk.sh b/tool/build_sdk.sh
index f114243b2bc535f8f4d6d07bd6f6f941c5394911..156e82672dc15d134a902afb06cd06d20327f317 100755
--- a/tool/build_sdk.sh
+++ b/tool/build_sdk.sh
@@ -9,36 +9,14 @@ dart -c tool/patch_sdk.dart tool/input_sdk gen/patched_sdk
echo "*** Compiling SDK to JavaScript"
# TODO(jmesserly): break out dart:html & friends.
-dart -c bin/dartdevc.dart \
+#
+# Right now we can't summarize our SDK, so we can't treat it as a normal
+# explicit input (instead we're implicitly compiling against the user's SDK).
+#
+# Another possible approach is to hard code the dart:* library->module mapping
+# into the compiler itself, so it can emit the correct import.
+#
+dart -c tool/build_sdk.dart \
--dart-sdk gen/patched_sdk \
-o lib/runtime/dart_sdk.js \
- --unsafe-force-compile --no-source-map --no-emit-metadata \
- dart:_runtime \
- dart:_debugger \
- dart:_foreign_helper \
- dart:_interceptors \
- dart:_internal \
- dart:_isolate_helper \
- dart:_js_embedded_names \
- dart:_js_helper \
- dart:_js_mirrors \
- dart:_js_primitives \
- dart:_metadata \
- dart:_native_typed_data \
- dart:async \
- dart:collection \
- dart:convert \
- dart:core \
- dart:isolate \
- dart:js \
- dart:math \
- dart:mirrors \
- dart:typed_data \
- dart:indexed_db \
- dart:html \
- dart:html_common \
- dart:svg \
- dart:web_audio \
- dart:web_gl \
- dart:web_sql \
"$@" > tool/sdk_expected_errors.txt
« no previous file with comments | « tool/build_sdk.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698