Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2261173003: Drop outdated comment in SVGClipPainter.h (Closed)

Created:
4 years, 4 months ago by fs
Modified:
4 years, 4 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop outdated comment in SVGClipPainter.h This FIXME/comment can no longer be considered relevant. (Dates back to when similar methods to prepareEffect/finishEffect lived in the LayoutSVGResourceContainer hierarchy.) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/cc17869244846f2d20b6dd718bb3afc7a627108a Cr-Commit-Position: refs/heads/master@{#413479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/paint/SVGClipPainter.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 4 months ago (2016-08-22 14:47:44 UTC) #5
Stephen Chennney
lgtm
4 years, 4 months ago (2016-08-22 14:50:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261173003/1
4 years, 4 months ago (2016-08-22 16:16:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 18:37:23 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 18:39:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc17869244846f2d20b6dd718bb3afc7a627108a
Cr-Commit-Position: refs/heads/master@{#413479}

Powered by Google App Engine
This is Rietveld 408576698