Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2261163003: Move gvr library proguard config to chrome_public_apk_tmpl.gni so that Chrome apk can also use it (Closed)

Created:
4 years, 4 months ago by bshe
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move gvr library proguard config to chrome_public_apk_tmpl.gni so that Chrome apk can also use it BUG=639888 Committed: https://crrev.com/fb7d18e14a7e1b9acaf65cd582e1080408259aae Cr-Commit-Position: refs/heads/master@{#413553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
bajones
Non-owner LGTM. Sorry I missed this on my first pass.
4 years, 4 months ago (2016-08-22 16:26:47 UTC) #2
bshe
Thanks Brandon. +David for owner approval Thanks!
4 years, 4 months ago (2016-08-22 17:48:47 UTC) #5
David Trainor- moved to gerrit
rubber stamp lgtm. :)
4 years, 4 months ago (2016-08-22 21:31:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261163003/1
4 years, 4 months ago (2016-08-22 22:19:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 22:27:00 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 22:29:30 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb7d18e14a7e1b9acaf65cd582e1080408259aae
Cr-Commit-Position: refs/heads/master@{#413553}

Powered by Google App Engine
This is Rietveld 408576698