Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 2261123003: [gn] add missing suppressions for linker warnings on windows (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] add missing suppressions for linker warnings on windows When doing a component build, some test binaries link against the object files directly, bypassing the components. This results, however, and rightly so, in linker warnings. In gyp, we just suppressed them. During the transition to gn, this was dropped for two binaries. Here I add the suppressions back in. Long term, we should either change the tests to go through the public API, or export the required symbols. BUG=chromium:633688 R=jkummerow@chromium.org Committed: https://crrev.com/24cb21e327645f0708dadb8abac473b6f09952cf Cr-Commit-Position: refs/heads/master@{#38793}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M BUILD.gn View 1 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/BUILD.gn View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-22 15:26:04 UTC) #1
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-22 15:38:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261123003/20001
4 years, 4 months ago (2016-08-22 15:45:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22282)
4 years, 4 months ago (2016-08-22 15:48:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261123003/20001
4 years, 4 months ago (2016-08-22 16:47:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 16:50:22 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 16:50:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24cb21e327645f0708dadb8abac473b6f09952cf
Cr-Commit-Position: refs/heads/master@{#38793}

Powered by Google App Engine
This is Rietveld 408576698