BUILD.gn - Issue 2261123003: [gn] add missing suppressions for linker warnings on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 2261123003: [gn] add missing suppressions for linker warnings on windows (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 30177d358587dc9c36c1f65f3bf3a1251252ae40..de1b11334ece805574ebae3f888e848efe997819 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -2456,6 +2456,16 @@ v8_executable("v8_parser_shell") {

if (v8_enable_i18n_support) {

deps += [ "//third_party/icu" ]

}

+ if (is_win) {

+ # Suppress warnings about importing locally defined symbols.

+ if (is_component_build) {

+ ldflags = [

+ "/ignore:4049",

+ "/ignore:4217",

+ ]

+ }

}

if (want_v8_shell) {

« no previous file with comments | « no previous file | test/cctest/BUILD.gn » ('j') | no next file with comments »