Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2261043002: Do not immediately block cross-renderer extension resource loads for non-web-triggered transitions (Closed)

Created:
4 years, 4 months ago by robwu
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Do not immediately block cross-renderer extension resource loads for non-web-triggered transitions This is a very conservative fix designed to fix the regression. The page transition logic was and is not in sync with the renderer-side check, see https://crbug.com/633963#c14. BUG=633963 TEST=manually using steps from bug report Review-Url: https://codereview.chromium.org/2249423002 Cr-Commit-Position: refs/heads/master@{#413258} (cherry picked from commit 45ec6fecc32bff5541c237c98228122f3252902e)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/extensions/chrome_url_request_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/url_request_util.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 1 (1 generated)
robwu
4 years, 4 months ago (2016-08-23 04:30:10 UTC) #1
Description was changed from

==========
Do not immediately block cross-renderer extension resource loads for
non-web-triggered transitions

This is a very conservative fix designed to fix the regression.
The page transition logic was and is not in sync with the renderer-side check,
see https://crbug.com/633963#c14.

BUG=633963
TEST=manually using steps from bug report

Review-Url: https://codereview.chromium.org/2249423002
Cr-Commit-Position: refs/heads/master@{#413258}
(cherry picked from commit 45ec6fecc32bff5541c237c98228122f3252902e)
==========

to

==========
Do not immediately block cross-renderer extension resource loads for
non-web-triggered transitions

This is a very conservative fix designed to fix the regression.
The page transition logic was and is not in sync with the renderer-side check,
see https://crbug.com/633963#c14.

BUG=633963
TEST=manually using steps from bug report

Review-Url: https://codereview.chromium.org/2249423002
Cr-Commit-Position: refs/heads/master@{#413258}
(cherry picked from commit 45ec6fecc32bff5541c237c98228122f3252902e)
==========

Powered by Google App Engine
This is Rietveld 408576698