Issue 2261043002: Do not immediately block cross-renderer extension resource loads for non-web-triggered transitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2261043002: Do not immediately block cross-renderer extension resource loads for non-web-triggered transitions (Closed)

Created:
4 years, 4 months ago by robwu

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do not immediately block cross-renderer extension resource loads for non-web-triggered transitions This is a very conservative fix designed to fix the regression. The page transition logic was and is not in sync with the renderer-side check, see https://crbug.com/633963#c14. BUG=633963 TEST=manually using steps from bug report Review-Url: https://codereview.chromium.org/2249423002 Cr-Commit-Position: refs/heads/master@{#413258} (cherry picked from commit 45ec6fecc32bff5541c237c98228122f3252902e)

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	chrome/browser/extensions/chrome_url_request_util.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	extensions/browser/url_request_util.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

robwu

4 years, 4 months ago (2016-08-23 04:30:10 UTC) #1

Description was changed from

==========
Do not immediately block cross-renderer extension resource loads for
non-web-triggered transitions

This is a very conservative fix designed to fix the regression.
The page transition logic was and is not in sync with the renderer-side check,
see https://crbug.com/633963#c14.

BUG=633963
TEST=manually using steps from bug report

Review-Url: https://codereview.chromium.org/2249423002
Cr-Commit-Position: refs/heads/master@{#413258}
(cherry picked from commit 45ec6fecc32bff5541c237c98228122f3252902e)
==========

to

==========
Do not immediately block cross-renderer extension resource loads for
non-web-triggered transitions

This is a very conservative fix designed to fix the regression.
The page transition logic was and is not in sync with the renderer-side check,
see https://crbug.com/633963#c14.

BUG=633963
TEST=manually using steps from bug report

Review-Url: https://codereview.chromium.org/2249423002
Cr-Commit-Position: refs/heads/master@{#413258}
(cherry picked from commit 45ec6fecc32bff5541c237c98228122f3252902e)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages