Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2827)

Unified Diff: extensions/browser/url_request_util.cc

Issue 2261043002: Do not immediately block cross-renderer extension resource loads for non-web-triggered transitions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/chrome_url_request_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/url_request_util.cc
diff --git a/extensions/browser/url_request_util.cc b/extensions/browser/url_request_util.cc
index 2450fa3e32eae6287d72999f3eee7b32c30a133b..1e44115bcb7c545ff28353e4785ae75006b309c7 100644
--- a/extensions/browser/url_request_util.cc
+++ b/extensions/browser/url_request_util.cc
@@ -49,7 +49,8 @@ bool AllowCrossRendererResourceLoad(net::URLRequest* request,
return true;
}
- if (!ui::PageTransitionIsWebTriggerable(info->GetPageTransition())) {
+ if (is_guest &&
+ !ui::PageTransitionIsWebTriggerable(info->GetPageTransition())) {
*allowed = false;
return true;
}
@@ -118,6 +119,11 @@ bool AllowCrossRendererResourceLoad(net::URLRequest* request,
return true;
}
+ if (!ui::PageTransitionIsWebTriggerable(info->GetPageTransition())) {
+ *allowed = false;
+ return true;
+ }
+
// Couldn't determine if the resource is allowed or not.
return false;
}
« no previous file with comments | « chrome/browser/extensions/chrome_url_request_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698