Log ErrorCode of Geoposition to UMA.

content/browser/geolocation/geolocation_dispatcher_host.cc

Index: content/browser/geolocation/geolocation_dispatcher_host.cc
diff --git a/content/browser/geolocation/geolocation_dispatcher_host.cc b/content/browser/geolocation/geolocation_dispatcher_host.cc
index edb2692f36f232894ace3e678a8a17d9ec4c43d8..013ace1aa830c574779b0b2c1eadb76f57b18bb2 100644
--- a/content/browser/geolocation/geolocation_dispatcher_host.cc
+++ b/content/browser/geolocation/geolocation_dispatcher_host.cc
@@ -148,6 +148,10 @@ bool GeolocationDispatcherHostImpl::OnMessageReceived(
 void GeolocationDispatcherHostImpl::OnLocationUpdate(
     const Geoposition& geoposition) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  UMA_HISTOGRAM_ENUMERATION(
+      "Geolocation.GeolocationDispatcherHostImpl.ErrorCode",
+      geoposition.error_code,
+      Geoposition::ERROR_CODE_LAST);

[Ilya Sherman, 2014/04/04 21:55:47]

I recommend against re-using an existing enumeration for metrics purposes,
especially since the existing enum is tied to an external specification.  Enums
used for histograms are required to be append-only over the lifetime of the
code, which is hard to guarantee in this case.  I'd recommend instead defining a
new enumeration specifically for metrics, with a simple conversion function to
translate from one to the other.

[Ilya Sherman, 2014/04/04 21:55:47]

For enumerated histograms, the final argument should be one-past-the-end of the
enum, rather than at the end of the enum.  This property allows you to add more
error codes over time, by separating out the overflow bucket from the bucket
that is currently the last one in the histogram.

[Michael van Ouwerkerk, 2014/04/07 14:02:35]

Done.

[Michael van Ouwerkerk, 2014/04/07 14:02:35]

Done.

   for (std::map<int, RendererGeolocationOptions>::iterator it =
        geolocation_renderers_.begin();
        it != geolocation_renderers_.end(); ++it) {