Log ErrorCode of Geoposition to UMA.

content/browser/geolocation/geolocation_dispatcher_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/geolocation/geolocation_dispatcher_host.h"
 
 #include <map>
 #include <set>
 #include <utility>
 
@@ skipping 130 matching lines @@
     IPC_MESSAGE_HANDLER(GeolocationHostMsg_StartUpdating, OnStartUpdating)
     IPC_MESSAGE_HANDLER(GeolocationHostMsg_StopUpdating, OnStopUpdating)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void GeolocationDispatcherHostImpl::OnLocationUpdate(
     const Geoposition& geoposition) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  UMA_HISTOGRAM_ENUMERATION(
+      "Geolocation.GeolocationDispatcherHostImpl.ErrorCode",
+      geoposition.error_code,
+      Geoposition::ERROR_CODE_LAST);

[Ilya Sherman, 2014/04/04 21:55:47]

I recommend against re-using an existing enumeration for metrics purposes,
especially since the existing enum is tied to an external specification.  Enums
used for histograms are required to be append-only over the lifetime of the
code, which is hard to guarantee in this case.  I'd recommend instead defining a
new enumeration specifically for metrics, with a simple conversion function to
translate from one to the other.

[Ilya Sherman, 2014/04/04 21:55:47]

For enumerated histograms, the final argument should be one-past-the-end of the
enum, rather than at the end of the enum.  This property allows you to add more
error codes over time, by separating out the overflow bucket from the bucket
that is currently the last one in the histogram.

[Michael van Ouwerkerk, 2014/04/07 14:02:35]

Done.

[Michael van Ouwerkerk, 2014/04/07 14:02:35]

Done.

   for (std::map<int, RendererGeolocationOptions>::iterator it =
        geolocation_renderers_.begin();
        it != geolocation_renderers_.end(); ++it) {
     if (!(it->second.is_paused))
       Send(new GeolocationMsg_PositionUpdated(it->first, geoposition));
   }
 }
 
 void GeolocationDispatcherHostImpl::OnRequestPermission(
     int render_view_id,
@@ skipping 135 matching lines @@
 }
 
 GeolocationDispatcherHost::GeolocationDispatcherHost()
     : BrowserMessageFilter(GeolocationMsgStart) {
 }
 
 GeolocationDispatcherHost::~GeolocationDispatcherHost() {
 }
 
 }  // namespace content