[Offline pages] Enabling notifications for pages saved later

components/offline_pages/background/request_notifier.h

Index: components/offline_pages/background/request_notifier.h
diff --git a/components/offline_pages/background/request_notifier.h b/components/offline_pages/background/request_notifier.h
index dfdc76e1074f740be022592f4c0a24852fb28557..25daaca053410ecc141f1f30c2ec5508b8eff964 100644
--- a/components/offline_pages/background/request_notifier.h
+++ b/components/offline_pages/background/request_notifier.h
@@ -23,6 +23,8 @@ class RequestNotifier {
     REMOVED,
   };
 
+  virtual ~RequestNotifier() = default;

[Pete Williamson, 2016/08/24 17:02:41]

This is fine, but why add it?  Should we be doing this everywhere?

[fgorski, 2016/08/24 18:25:23]

http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors
http://www.programmerinterview.com/index.php/c-cplusplus/virtual-destructors/

I agree that we might not need it here, because of how me manage RC lifecycle,
but given that you can still inherit from this one outside of RC, we probably
want to keep it virtual.

+
   // Notifies observers that |request| has been added.
   virtual void NotifyAdded(const SavePageRequest& request) = 0;