components/offline_pages/downloads/BUILD.gn - Issue 2260963003: [Offline pages] Enabling notifications for pages saved later

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/downloads/BUILD.gn

Issue 2260963003: [Offline pages] Enabling notifications for pages saved later (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/background/request_notifier.h ('K') | « components/offline_pages/background/request_notifier.h ('k') | components/offline_pages/downloads/download_notifying_observer.h » ('j') | components/offline_pages/downloads/download_notifying_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/downloads/BUILD.gn

diff --git a/components/offline_pages/downloads/BUILD.gn b/components/offline_pages/downloads/BUILD.gn

index 55fd463fdec0f4eaa9c339c143b7d0881f5f01b6..90821a2eb2e8454fab9655bf3de9e6333aacd7a4 100644

--- a/components/offline_pages/downloads/BUILD.gn

+++ b/components/offline_pages/downloads/BUILD.gn

@@ -9,6 +9,8 @@ if (is_android) {

# GYP: //components/offline_pages.gypi:offline_pages_ui_adapter

static_library("offline_pages_ui_adapter") {

sources = [

+ "download_notifying_observer.cc",

+ "download_notifying_observer.h",

"download_ui_adapter.cc",

"download_ui_adapter.h",

"download_ui_item.cc",

@@ -19,6 +21,7 @@ static_library("offline_pages_ui_adapter") {

deps = [

"//base",

"//components/offline_pages:offline_pages",

+ "//components/offline_pages/background:background_offliner",

"//url",

]

}

@@ -26,6 +29,7 @@ static_library("offline_pages_ui_adapter") {

source_set("unit_tests") {

testonly = true

sources = [

+ "download_notifying_observer_unittest.cc",

"download_ui_adapter_unittest.cc",

]