Move default begin frame sources out to mus

services/ui/public/cpp/output_surface.cc

Index: services/ui/public/cpp/output_surface.cc
diff --git a/services/ui/public/cpp/output_surface.cc b/services/ui/public/cpp/output_surface.cc
index ed236960c10d6f4935320075bfb974501dc2f208..50a1372f437d5c6800df8664c2544f4f0bb69e99 100644
--- a/services/ui/public/cpp/output_surface.cc
+++ b/services/ui/public/cpp/output_surface.cc
@@ -8,6 +8,7 @@
 #include "cc/output/compositor_frame.h"
 #include "cc/output/output_surface_client.h"
 #include "services/ui/public/cpp/context_provider.h"
+#include "services/ui/public/cpp/gpu_service.h"
 #include "services/ui/public/cpp/window_surface.h"
 
 namespace ui {
@@ -19,6 +20,11 @@ OutputSurface::OutputSurface(GpuService* gpu_service,
                         nullptr),
       surface_(std::move(surface)) {
   capabilities_.delegated_rendering = true;
+
+  // TODO(enne): Get this from the WindowSurface via ServerWindowSurface.
+  begin_frame_source_.reset(new cc::DelayBasedBeginFrameSource(
+      base::MakeUnique<cc::DelayBasedTimeSource>(
+          gpu_service->main_task_runner().get())));

[Fady Samuel, 2016/08/22 15:16:52]

We shouldn't be giving it the main task runner right? it should be the
compositor's task runner?

 }
 
 OutputSurface::~OutputSurface() {}
@@ -26,10 +32,12 @@ OutputSurface::~OutputSurface() {}
 bool OutputSurface::BindToClient(cc::OutputSurfaceClient* client) {
   surface_->BindToThread();
   surface_->set_client(this);
+  client->SetBeginFrameSource(begin_frame_source_.get());

[sadrul, 2016/08/22 14:46:40]

Should |begin_frame_source_| be created here? (considering that OutputSurface
can be constructed in one thread, and BindToClient() can be called in a
different thread)

[Fady Samuel, 2016/08/22 15:16:52]

+1

   return cc::OutputSurface::BindToClient(client);
 }
 
 void OutputSurface::DetachFromClient() {
+  client_->SetBeginFrameSource(nullptr);
   surface_.reset();
   cc::OutputSurface::DetachFromClient();
 }