Move default begin frame sources out to mus

services/ui/public/cpp/output_surface.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/public/cpp/output_surface.h"
 
 #include "base/bind.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/output/output_surface_client.h"
 #include "services/ui/public/cpp/context_provider.h"
+#include "services/ui/public/cpp/gpu_service.h"
 #include "services/ui/public/cpp/window_surface.h"
 
 namespace ui {
 
 OutputSurface::OutputSurface(GpuService* gpu_service,
                              std::unique_ptr<ui::WindowSurface> surface)
     : cc::OutputSurface(make_scoped_refptr(new ContextProvider(gpu_service)),
                         nullptr,
                         nullptr),
       surface_(std::move(surface)) {
   capabilities_.delegated_rendering = true;
+
+  // TODO(enne): Get this from the WindowSurface via ServerWindowSurface.
+  begin_frame_source_.reset(new cc::DelayBasedBeginFrameSource(
+      base::MakeUnique<cc::DelayBasedTimeSource>(
+          gpu_service->main_task_runner().get())));

[Fady Samuel, 2016/08/22 15:16:52]

We shouldn't be giving it the main task runner right? it should be the
compositor's task runner?

 }
 
 OutputSurface::~OutputSurface() {}
 
 bool OutputSurface::BindToClient(cc::OutputSurfaceClient* client) {
   surface_->BindToThread();
   surface_->set_client(this);
+  client->SetBeginFrameSource(begin_frame_source_.get());

[sadrul, 2016/08/22 14:46:40]

Should |begin_frame_source_| be created here? (considering that OutputSurface
can be constructed in one thread, and BindToClient() can be called in a
different thread)

[Fady Samuel, 2016/08/22 15:16:52]

+1

   return cc::OutputSurface::BindToClient(client);
 }
 
 void OutputSurface::DetachFromClient() {
+  client_->SetBeginFrameSource(nullptr);
   surface_.reset();
   cc::OutputSurface::DetachFromClient();
 }
 
 void OutputSurface::BindFramebuffer() {
   // This is a delegating output surface, no framebuffer/direct drawing support.
   NOTREACHED();
 }
 
 uint32_t OutputSurface::GetFramebufferCopyTextureFormat() {
@@ skipping 15 matching lines @@
     ui::WindowSurface* surface,
     mojo::Array<cc::ReturnedResource> resources) {
   ReclaimResources(resources.To<cc::ReturnedResourceArray>());
 }
 
 void OutputSurface::SwapBuffersComplete() {
   client_->DidSwapBuffersComplete();
 }
 
 }  // namespace ui