components/ntp_snippets/ntp_snippets_service.h - Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.h

Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace function pointer, use multiple if-continue Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/content_suggestions_service_unittest.cc ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_service.h

diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h

index f83d67264dfca9982622c265996d4fea8af0d839..fc0b4b9a5e4c7a4ecf51eebfc271b4f0aab23ed6 100644

--- a/components/ntp_snippets/ntp_snippets_service.h

+++ b/components/ntp_snippets/ntp_snippets_service.h

@@ -138,8 +138,9 @@ class NTPSnippetsService : public image_fetcher::ImageFetcherDelegate,

void FetchSuggestionImage(const std::string& suggestion_id,

const ImageFetchedCallback& callback) override;

void ClearCachedSuggestionsForDebugging(Category category) override;

- std::vector<ContentSuggestion> GetDismissedSuggestionsForDebugging(

- Category category) override;

+ void GetDismissedSuggestionsForDebugging(

+ Category category,

+ const DismissedSuggestionsCallback& callback) override;

void ClearDismissedSuggestionsForDebugging(Category category) override;

// Returns the lists of suggestion hosts the snippets are restricted to.

« no previous file with comments | « components/ntp_snippets/content_suggestions_service_unittest.cc ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »