components/ntp_snippets/content_suggestions_service_unittest.cc - Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_service_unittest.cc

Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace function pointer, use multiple if-continue Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/ntp_snippets/content_suggestions_service_unittest.cc

diff --git a/components/ntp_snippets/content_suggestions_service_unittest.cc b/components/ntp_snippets/content_suggestions_service_unittest.cc

index 7cdc12dfdbf6b12438020e89a25c1b72c853d748..600879566f1ee764d9160cc9bbfdbe02f9725931 100644

--- a/components/ntp_snippets/content_suggestions_service_unittest.cc

+++ b/components/ntp_snippets/content_suggestions_service_unittest.cc

@@ -100,8 +100,9 @@ class MockProvider : public ContentSuggestionsProvider {

}

MOCK_METHOD1(ClearCachedSuggestionsForDebugging, void(Category category));

- MOCK_METHOD1(GetDismissedSuggestionsForDebugging,

- std::vector<ContentSuggestion>(Category category));

+ MOCK_METHOD2(GetDismissedSuggestionsForDebugging,

+ void(Category category,

+ const DismissedSuggestionsCallback& callback));

MOCK_METHOD1(ClearDismissedSuggestionsForDebugging, void(Category category));

MOCK_METHOD1(DismissSuggestion, void(const std::string& suggestion_id));

MOCK_METHOD2(FetchSuggestionImage,

« no previous file with comments | « components/ntp_snippets/content_suggestions_service.cc ('k') | components/ntp_snippets/ntp_snippets_service.h » ('j') | no next file with comments »