components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h - Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace function pointer, use multiple if-continue Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/snippets_internals_message_handler.cc ('k') | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

index 1f2aabd146a4e65863de12dedf7a31f9c24dfc00..94be2ca7ccabc7b245d581660b19ed9d536a5503 100644

--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

@@ -38,8 +38,9 @@ class BookmarkSuggestionsProvider : public ContentSuggestionsProvider,

void FetchSuggestionImage(const std::string& suggestion_id,

const ImageFetchedCallback& callback) override;

void ClearCachedSuggestionsForDebugging(Category category) override;

- std::vector<ContentSuggestion> GetDismissedSuggestionsForDebugging(

- Category category) override;

+ void GetDismissedSuggestionsForDebugging(

+ Category category,

+ const DismissedSuggestionsCallback& callback) override;

void ClearDismissedSuggestionsForDebugging(Category category) override;

// bookmarks::BookmarkModelObserver implementation.