components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc - Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2260783002: Make GetDismissedSuggestionsForDebugging asynchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace function pointer, use multiple if-continue Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h ('k') | components/ntp_snippets/content_suggestions_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

index 04395e5c570d511e5f7abd467f852a0437dedffc..00a08d19764872d97ec94186e39110139e2b632e 100644

--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

@@ -127,9 +127,9 @@ void BookmarkSuggestionsProvider::ClearCachedSuggestionsForDebugging(

// Ignored.

}

-std::vector<ContentSuggestion>

-BookmarkSuggestionsProvider::GetDismissedSuggestionsForDebugging(

- Category category) {

+void BookmarkSuggestionsProvider::GetDismissedSuggestionsForDebugging(

+ Category category,

+ const DismissedSuggestionsCallback& callback) {

DCHECK_EQ(category, provided_category_);

std::vector<const BookmarkNode*> bookmarks =

GetDismissedBookmarksForDebugging(bookmark_model_);

@@ -137,7 +137,7 @@ BookmarkSuggestionsProvider::GetDismissedSuggestionsForDebugging(

std::vector<ContentSuggestion> suggestions;

for (const BookmarkNode* bookmark : bookmarks)

suggestions.emplace_back(ConvertBookmark(bookmark));

- return suggestions;

+ callback.Run(std::move(suggestions));

}

void BookmarkSuggestionsProvider::ClearDismissedSuggestionsForDebugging(